link to comment in complete thread context [#97]

[this is the same as bug report #37 - i put it here again as it isn't a bug really]

1 comment attached to node "xxx":
>>>comment "yyy"<<<

should link to

[original node]
[first comment]
[second comment]
...
>>>[comment "yyy"]

instead of

[original node]
>>>[comment "yyy"]

to have the context and avoid having to browse back and forth for it.

this has been solved (i think) - see http://list.drupal.org/drupal-devel/2002-February/thread.html#6755. just has to be applied ;)

Comments

Comment #1

(not verified) CreditAttribution: commented 19 May 2002 at 23:23

The comment behaviour has been changed to mostly act as described.

Comment #2

ax CreditAttribution: ax commented 16 July 2002 at 06:35

Title:	"new comments": link to comment in complete thread context	» link to comment in complete thread context
Component:	Code	» tracker.module

not fixed. it's the links to the comments in tracker.module that have to be changed. from

node.php?id=2296&cid=142&pid=134#142

node.php?id=2296#142

(see http://list.drupal.org/drupal-devel/2002-February/006755.html)

additionally, every comment view (threaded, full, collapsed)must specify an anchor (<a name="[cid]">) for every comment shown. currently, flat (and more) doesnt have this.

i think the id=2296&cid=142&pid=134#142 should be changed in all other places (comment.module), too.

Comment #3

ax CreditAttribution: ax commented 4 September 2002 at 17:09

Priority:

Major

» Normal

could someone please implement this in cvs? i find it horrible to click on a "recent comment" in tracker and then only get this comment and the /root/ node and /not/ all the comments leading to this one (so that i have to browser back and click the node to see the comment i responded to).

here's the diff:


Index: tracker.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/tracker.module,v
retrieving revision 1.27
diff -u -r1.27 tracker.module
--- tracker.module	2002/06/27 09:41:55	1.27
+++ tracker.module	2002/09/04 16:46:55
@@ -48,7 +48,7 @@
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;$output .= &quot;&lt;ul&gt;&quot;;
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;while ($comment = db_fetch_object($cresult)) {
-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;$output .= &quot; &lt;li&gt;&quot;. l(check_output($comment-&gt;subject), array(&quot;id&quot; =&gt; $node-&gt;nid, &quot;cid&quot; =&gt; $comment-&gt;cid, &quot;pid&quot; =&gt; $comment-&gt;pid), &quot;node&quot;, $comment-&gt;cid) .&quot; &quot;. t(&quot;by&quot;) .&quot; &quot;. format_name($comment) .&quot; (&quot;. t(&quot;replies&quot;) .&quot;: &quot;. comment_num_replies($comment-&gt;cid) .&quot;) &quot;. (comment_is_new($comment) ? &quot;&lt;span style=\&quot;color: red;\&quot;&gt;*&lt;/span&gt;&quot; : &quot;&quot;) .&quot;&lt;/li&gt;\n&quot;;
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;$output .= &quot; &lt;li&gt;&quot;. l(check_output($comment-&gt;subject), array(&quot;id&quot; =&gt; $node-&gt;nid), &quot;node&quot;, $comment-&gt;cid) .&quot; &quot;. t(&quot;by&quot;) .&quot; &quot;. format_name($comment) .&quot; (&quot;. t(&quot;replies&quot;) .&quot;: &quot;. comment_num_replies($comment-&gt;cid) .&quot;) &quot;. (comment_is_new($comment) ? &quot;&lt;span style=\&quot;color: red;\&quot;&gt;*&lt;/span&gt;&quot; : &quot;&quot;) .&quot;&lt;/li&gt;\n&quot;;
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;$output .= &quot; &lt;/ul&gt;\n&quot;;
&nbsp;&nbsp;&nbsp;}

(hope this comes out properly in the project mail ...)

thanks!

btw: there is still that <span style="color: red;">*</span> in here which is "considered harmful". see this feature request.