In _bakery_register_submit() there is no checking if "profile" module exists like it's in bakery_settings().

Comments

greggles’s picture

Can you specify what kinds of problems that causes?

mjanouch’s picture

It can result to SQL error "Table profile_fields doesn't exist query: SELECT name FROM profile_fields WHERE register = 1..."

greggles’s picture

greggles’s picture

Status: Active » Needs review
StatusFileSize
new1.38 KB

Something like this?

greggles’s picture

Status: Needs review » Reviewed & tested by the community

I was able to test this by registering on a subsite. Without the patch we get the message:"User warning: Table 'sd6.profile_fields' doesn't exist query: SELECT name FROM profile_fields WHERE register = 1 in _db_query() (line 141 of /home/greggles/workspace/d6/includes/database.mysqli.inc)."

With the patch no error message about a missing table. I tested that the functionality still works as expected with editing a profile field on master and getting updated on slave and it does.

I plan to commit this shortly but leave it RTBC for others to provide input.

gábor hojtsy’s picture

The same error pops up all the time on localize.drupal.org. #971252: profile table database error was submitted based on that (and was marked duplicate). Please commit, so we can roll it out on l.d.o as well.

greggles’s picture

Title: Missing "profile" check » Missing profile.module check causes failed queries
Status: Reviewed & tested by the community » Patch (to be ported)
gábor hojtsy’s picture

Thanks, rolled out on localize.drupal.org with other Drupal 6.x-2.x changes with the alpha2.

drumm’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

I don't think this needs to be backported to 6.x, since Drupal 6 will be unsupported in a few months.