Cross-volume backup failure

That is the backup version control engine. It is used by pm-updatecode but not by pm-download. Anyway it seems it is enough to switch to drush_move_dir(). untested.

Comitted.

When upgrading Drupal Core, the directory could not be moved. Moving the backup directory to the same volume resolved my issues. (See #1094366: update drupal core fails because the temporary files can’t be moved.)

I guess re-opening is appropriate?

I'm confused on this one. I'm getting the same error that rolfmeijer is over in #1094366: update drupal core fails because the temporary files can’t be moved:

Executing: mkdir '/path/to/home-dir/drush-backups/science_drupal/20110531202301'
Calling is_readable(/var/www/html/drupal/dev/drupal-7.2)
Calling is_writable(/path/to/home-dir/drush-backups/science_drupal/20110531202301)
Calling rename(/var/www/html/drupal/dev/drupal-7.2, /path/to/home-dir/drush-backups/science_drupal/20110531202301/drupal)
Drush command terminated abnormally due to an unrecoverable error.                                                                                             [error]
Error: require_once(): Failed opening required '/var/www/html/drupal/dev/includes/errors.inc' (include_path='.:/usr/share/pear:/usr/share/php') in
/var/www/html/drupal/dev/includes/bootstrap.inc, line 2094 [28.99 sec, 33.28 MB]

Running "drush up" with "--backup-dir=/this/dir" was a workaround, but isn't this still an issue that needs fixed?

My server situation is RHEL 6 with Drush 4.4 AND automounted user folders (which is why I'm guessing I'm getting this error [ie. #1094366: update drupal core fails because the temporary files can’t be moved]).

rolfmeijer, you reopened this. Are you using drush 5.x-dev or 4.4?

I’m using 5.x-dev

From drush_move_dir():

  // Try rename. It will fail if $src and $dest are not in the same partition.
  if (@drush_op('rename', $src, $dest)) {
    return TRUE;
  }

Perhaps changing this nasty @ to a try/catch may help. Patch attached. Untested.

ps. there's no try/catch/else construct for php? of course python has ;) http://docs.python.org/whatsnew/2.5.html#pep-341

The patch

+1

Looks good. If you tested the failure scenario and it works as expected, then this is RTBC. Thanks jonhattan.

I was able to reproduce this error and found a proper solution. See #1204862: drush up can't update D7 because of drupal error handler intervention..

marking this one as duplicated of the other.