If you remove the comment form with alters you get notices. This patch is utterly trivial as !empty and (implicit) cast to bool always lead to the same result just without the notices.

CommentFileSizeAuthor
#5 drupal.comment-form-empty.5.patch762 bytessun
comment_form_empty.patch1.03 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented

Looks like a no-brainer - but :
Do we clutter templates with isset()s, or make sure the variable is at least an empty string / empty array ?

Dries’s picture

Dries CreditAttribution: Dries commented

The majority of the template files don't use isset()s, but it is not entirely consistent.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

seems like this is pretty clear and committable as is.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Reviewed & tested by the community » Needs work

yched and Dries are right, we don't use !empty() or isset() in template files.

http://api.drupal.org/api/drupal/modules--comment--comment.module/functi...

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal.comment-form-empty.5.patch762 bytes
yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Looks nicer :-)

chx’s picture

chx CreditAttribution: chx commented

AWESOME thanks.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.