If then admin toolbar is expanded and an overlay is opened the over is obscured. The work around is to close then reopen the admin toolbar, which is annoying.

CommentFileSizeAuthor
#4 Screen Shot 2011-09-20 at 3.07.32 PM.png288.64 KBattheshow
#4 Screen Shot 2011-09-20 at 3.07.34 PM.png290.29 KBattheshow
#1 admin-958182-covering-overlay.diff6.86 KBskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new admin-958182-covering-overlay.diff6.86 KB

The attached patch fixes this issue. There are a couple of related changes rolled into the patch too, they are:

* Moving width/height from a magic number to a constant (Drupal.adminToolbar.SIZE)

* Move resize overlay resize animation into a separate method (setOverlayState) and reduce code duplication

I am binding to the drupalOverlayLoad event rather than the drupalOverlayOpen event, as the open event seems to fire before the admin toolbar behaviors are setup. The down side is some extra logic will be executed on each overlay load.

I may have gone overboard on the documentation for setOverlayState, feel free to trim it.

yhahn’s picture

yhahn commented
Status: Needs review » Fixed

Thanks, http://drupal.org/cvs?commit=465704

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

attheshow’s picture

attheshow commented
Version: 7.x-2.0-beta2 » 7.x-2.0-beta3
Status: Closed (fixed) » Active
StatusFileSize
new Screen Shot 2011-09-20 at 3.07.34 PM.png290.29 KB
new Screen Shot 2011-09-20 at 3.07.32 PM.png288.64 KB

I'm still seeing this in 7.x-2.0-beta3. Screenshots attached.

skwashd’s picture

skwashd commented
Status: Active » Fixed

This is fixed in the current nightly builds. See r-35fe189.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

abaddon’s picture

abaddon commented
Status: Closed (fixed) » Active

this still doesnt work correctly if State on new pages: Collapsed

sickness29’s picture

sickness29 commented
Issue summary: View changes
Status: Active » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Everyone can apply the patch above (not tested by the maintainers, tested by the community) to their D7 projects.
If the issue remains relevant for D10+ versions, merge requests with proposed solutions for a new module version (D10+) are welcome in a new follow-up issue.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.