Suggest this changes to match cores node content exposed filters, sorry I can't roll a patch right now but had a crack at hacking theme_skinr_ui_filters. I'd be slightly tempted to call this a bug actually since we need to special case whereas it could just inherit cores exposed filter style from system.admin.css

Something like (although I'm pretty sure I'm missing a div in there somewhere)...

  $output .= '<div class="exposed-filters clearfix">';

  if (!empty($form['status']) && count(element_children($form['status']))) {
    $output .= '<div class="filters form-wrapper">' . (!empty($form['current']) ? '<div class="form-item form-type-select"><em>' . t('and') . '</em> ' . t('where') . '</div>' : '');

    foreach (element_children($form['status']) as $key) {
      $output .= drupal_render($form['status'][$key]);
    }

    $output .= '</div>';
  }
  $output .= drupal_render($form['actions']);

  $output .= '</div>';
CommentFileSizeAuthor
#5 957388-5-skinr-exposed-filters.patch6.41 KBjacine
#3 skinr-exposed-filters.patch6.37 KBjacine

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Category: feature » bug

Yup, on the list. Thanks for posting the issue for me :)

jacine’s picture

jacine
she/her
Location New York
commented
Assigned: Unassigned » jacine

Gonna do this on Friday, since I worked on the patch that fixed this horrendous markup. :)

jacine’s picture

jacine
she/her
Location New York
commented
Category: bug » task
Status: Active » Needs review
StatusFileSize
new skinr-exposed-filters.patch6.37 KB

Here's a patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented 
+++ skinr_ui.admin.inc	12 Nov 2010 19:07:48 -0000
@@ -86,9 +87,19 @@ function skinr_ui_filter_form() {
   }
 
+ $form['filters']['status'] = array(
...
+ );
+
   foreach ($filters as $key => $filter) {

Wrong indentation.

Powered by Dreditor.

jacine’s picture

jacine
she/her
Location New York
commented
StatusFileSize
new 957388-5-skinr-exposed-filters.patch6.41 KB

Thanks!

Fixed :D

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community 
+++ skinr_ui.admin.inc	12 Nov 2010 19:27:54 -0000
@@ -86,9 +87,19 @@ function skinr_ui_filter_form() {
+  $form['filters']['status'] = array(
+    '#type' => 'container',
+    '#attributes' => array('class' => array('clearfix')),
+    '#prefix' => ($i ? '<div class="additional-filters">' . t('and where') . '</div>' : ''),
+  );
+   $form['filters']['status']['filters'] = array(
+     '#type' => 'container',
+     '#attributes' => array('class' => array('filters')),
+   );

Again wrong indentation, but can be fixed prior to committing. ;)

Powered by Dreditor.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Reviewed & tested by the community » Fixed

Committed! Thanks :D

http://drupal.org/cvs?commit=449932

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.