Just some coding standard things to clean up http://api.drupal.org/api/function/menu_set_active_trail/6

Files: 
CommentFileSizeAuthor
#5 menu_set_active_trail-d7-956320-5.patch1.21 KBdstol
PASSED: [[SimpleTest]]: [MySQL] 26,751 pass(es). View
#4 menu_set_active_trail-956320-4.patch1.57 KBdstol
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-4.patch. View
#1 menu_set_active_trail-956320-1.patch1.57 KBdstol
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-1.patch. View

Comments

dstol’s picture

FileSize
1.57 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-1.patch. View

Here's the patch.

jhodgdon’s picture

Status: Needs review » Needs work

Cleaning up is OK, but not a very high priority for Drupal 6 at this time. I'd also avoid filing huge cleanup patches for D7 (small ones like this would be OK).

This is not quite right:

+ *   - type: A menu type constant, such as MENU_DEFAULT_LOCAL_TASK, or 0 to
+ *      indicate it's not really in the menu (used for the home page item).

Indentation on the 2nd line should be two additional spaces, not 3.

jhodgdon’s picture

Version: 6.x-dev » 7.x-dev

Oh.

Actually, this same formatting problem exists in D7 too. We need to fix it there before we can accept a patch for D6.

dstol’s picture

Version: 7.x-dev » 6.x-dev
Status: Needs work » Needs review
FileSize
1.57 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch menu_set_active_trail-956320-4.patch. View

D6 fixup, D7 coming.

dstol’s picture

Version: 6.x-dev » 7.x-dev
FileSize
1.21 KB
PASSED: [[SimpleTest]]: [MySQL] 26,751 pass(es). View

D7 cleanup removing the single quotes.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

The D7 patch in #5 is fine. thanks.

The D6 patch in #4 is also fine. So after committing to D7, please set to D6 / RTBC, thanks...

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

dstol’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community

Setting as RTBC for 6.x-dev as per #6

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.