Fix the notice

CommentFileSizeAuthor
#6 956316-bakery-notices.patch621 bytescoltrane
#5 956316-bakery-notices.patch1.75 KBcoltrane
#3 956316-cookie-notices.patch830 bytescoltrane
#2 956316-cookie-notices.patch893 bytescoltrane
#1 956316-cookie-notice.patch513 bytescoltrane

Comments

coltrane’s picture

coltrane
he/him
commented
Status: Active » Needs review
StatusFileSize
new 956316-cookie-notice.patch513 bytes
coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 956316-cookie-notices.patch893 bytes

Another notice below it in bakery_user_logout()

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 956316-cookie-notices.patch830 bytes

This is better so we never get a notice on $destination.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: PHP Notice $destroy_cookie » PHP Notice $destroy_cookie and $destination
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Now committed to 6.x http://drupal.org/cvs?commit=443742

Just needs to be ported to 7.x.

coltrane’s picture

coltrane
he/him
commented
Title: PHP Notice $destroy_cookie and $destination » PHP Notices
StatusFileSize
new 956316-bakery-notices.patch1.75 KB

Ugh, seeing more of these.

coltrane’s picture

coltrane
he/him
commented
StatusFileSize
new 956316-bakery-notices.patch621 bytes

This one over #5 as it fits what was committed to D7.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks, Ben http://drupal.org/cvs?commit=445208

The patch in #6 is already done in d7, so no need to do anything with it in 7.x.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented
Status: Patch (to be ported) » Fixed

All changes of those patches are present in the current 7.x-2.x-alpha3 release so I'm marking this issue as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.