Show a more descriptive title for each setting on admin/appearance/skinr

Hi @Anticosti,

I totally agree. We're actually planning to do this shortly, but it will happen in the Drupal 7 version first.

Thanks for opening this issue! You just saved me the hassle of having to write it up. ;)

Figuring out the label of all skinable elements is going to be problematic. For D7 entities, it's less of a problem, since the entity system provides a helper function to retrieve the label, but blocks are not entities yet.

Regardless of that, more fundamental question:

What if you apply a skin to all blocks of a certain type?

We don't need show the Skinr ID anymore. It's not useful. We need a more descriptive and helpful title. What is there now is not helpful. Unless you understand block-module-delta it's useless. I don't see what's so hard about showing this information. Quicktabs does this.

What if you apply a skin to all blocks of a certain type?

This is not possible right now. It will be soon when we start using the rules UI. Those settings all need to be named, so this will not be a problem because we'd be able to use that as the title.

Hello,

This is my first patch, so please review it carefully. I put a new function, skinr_ui_item_name($type, $sid), in the skinr_ui.module file. I'm not 100% positive if this is the best place for it.

I've added human readable names for each type of skinr element, and made sure that sorting still works.

The method of getting the block name involved splitting the skinr id with strstr on the first occurrance of '-'. This should work as long as the module name always uses underscores. (I tested it with the Devel Node Access module).

I know it's a small feature, but I hope this brings skinr one step closer to a stable release. Jacine, If changes are necessary, I can make them and resubmit the patch.

This seems to workfor blocks but on node types, my 'article' node type is appearing as 'basic page' when the title is 'lorem ipsum dolor sit amet'

@nomonstersinme: That would be correct. Applying skins to node types is what you have... you currently can't apply it to individual nodes.

sub

@moonray its not displaying the node type properly. its telling me my node type is 'basic page' when its an 'article'

@nomonstersinme Ah. I read that wrong, then. Looks like it needs some fixing then.

$node = node_type_get_type('page'); should probably be $node = node_type_get_type($sid);

skinr_ui_item_name() should probably be broken out into its individual functionality plugins (e.g. modules/block.skinr.inc, modules/node.skinr.inc, etc.) using callbacks, rather than skinr_ui directly.

Having said that, in the future we'll have to re-evaluate the functionality plugin structure to minimize their impact on performance, though.

EDIT: And we need simpletests for all added/modified functionality.

Here's a new patch that uses a hook that returns the title based on module, element, and theme. It also includes tests and works with the latest version of Skinr.

Committed this patch.