Just noticed this last week. There is no need for $mapping to be passed by reference in rdf_mapping_save.

It has the negative effect of giving an error if someone calls the function like this

rdf_mapping_save(array('mapping' => $mapping, ....));
CommentFileSizeAuthor
#4 rdf-reference-953494-4.patch2.38 KBngmaloney
#1 rdf_fix.patch2.59 KBngmaloney

Comments

ngmaloney’s picture

ngmaloney commented
StatusFileSize
new rdf_fix.patch2.59 KB

Attached is a patch. New test was included that asserts hook can be executed with both a variable argument and an array declaration argument.

scor’s picture

scor commented
Status: Active » Needs review

Nice, and it comes with a test :)

scor’s picture

scor commented
Status: Needs review » Needs work 
+++ modules/rdf/rdf.test	9 Dec 2010 00:49:35 -0000
@@ -695,3 +695,42 @@ class RdfGetRdfNamespacesTestCase extend
+      'description' => 'Test hook rdf_mapping_save() and assert it will save an argument passed as an array. (Bug fix #953494)',

I don't think we should include bug report # here.

Powered by Dreditor.

ngmaloney’s picture

ngmaloney commented
Assigned: Unassigned » ngmaloney
StatusFileSize
new rdf-reference-953494-4.patch2.38 KB

Attached is patched revision, removing bug reference comment.

ngmaloney’s picture

ngmaloney commented
Status: Needs work » Needs review
scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community

looks good now, thanks ngmaloney!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.