Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just noticed this last week. There is no need for $mapping to be passed by reference in rdf_mapping_save.
It has the negative effect of giving an error if someone calls the function like this
rdf_mapping_save(array('mapping' => $mapping, ....));
Comment | File | Size | Author |
---|---|---|---|
#4 | rdf-reference-953494-4.patch | 2.38 KB | ngmaloney |
#1 | rdf_fix.patch | 2.59 KB | ngmaloney |
Comments
Comment #1
ngmaloney CreditAttribution: ngmaloney commentedAttached is a patch. New test was included that asserts hook can be executed with both a variable argument and an array declaration argument.
Comment #2
scor CreditAttribution: scor commentedNice, and it comes with a test :)
Comment #3
scor CreditAttribution: scor commentedI don't think we should include bug report # here.
Powered by Dreditor.
Comment #4
ngmaloney CreditAttribution: ngmaloney commentedAttached is patched revision, removing bug reference comment.
Comment #5
ngmaloney CreditAttribution: ngmaloney commentedComment #6
scor CreditAttribution: scor commentedlooks good now, thanks ngmaloney!
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.