It is my understanding that it should be possible to enable the Panels Everywhere site template and still provide our own custom page.tpl.php (i.e. not have to use the simplified page.tpl.php provided by Panels Everywhere).

But unchecking the box to "Override the page template" also disables the site template, even though the checkboxes for "Enable Panels Everywhere site template" is checked.

Issues #866090: edite site template panel and #906436: "Override the page template" cannot be disabled deal with aspects of this problem but offer partial and conflicting solutions.

Tested with:
panels_everywhere-6.x-1.x-dev panels-6.x-3.x-dev ctools-6.x-1.x-dev

CommentFileSizeAuthor
#6 panels_everywhere_bug_template.patch692 bytesayalon

Comments

sleeping_at-work-’s picture

sleeping_at-work- commented

Have a look to http://drupal.org/node/872260#comment-3327300 : with PE -dev release you need to "explicitly enable the "Override page template" option (or do it per-theme)" in order to have PE turned on

zach harkey’s picture

zach harkey commented

Are you saying there is currently no way to enable Panels Everywhere's Site Template with a custom page.tpl.php?

To put the question another way — If I want to use a Site Template variant, I have no choice but to use the simplified page.tpl.php provided by the module?

I'm confused because the instructions on the Settings > Everywhere page strongly imply that we can use our own page.tpl.php if we need to have more control over the final page template.

In my case, I am unable to create a Panels Everywhere theme based on HTML5 Boilerplate because explicitly enabling the "Override page template" option forces the simplified (XHTML 1.0 Strict) page.tpl.php file to load — but disabling the option also disables the site template.

(This isn't limited to -dev. If you uncheck the "Override page template" option in 6.x-1.1, you get a white screen of death: #866090: edite site template panel)

sleeping_at-work-’s picture

sleeping_at-work- commented

You can use PE 6.x-1.1 and apply the patch you find @ http://drupal.org/node/866090, with PE -dev release actually there's no way to use your custom page.tpl.php, I don't know if it's going to change ...

zach harkey’s picture

zach harkey commented

sleeping_at-work's suggestion of reverting to 6.x-1.1 and applying the patch from #866090 does restore the expected behavior (thanks, btw). Now I can Enable Panels Everywhere site template without having to let PE also Override the page template.

I really hope this is the intended behavior. If not, we need to rewrite the instructions to be more clear.

Would it be appropriate to change the status of #866090 from 'closed (fixed)' back to 'active'?

sleeping_at-work-’s picture

sleeping_at-work- commented

Don't know, I've been posting in two issues (http://drupal.org/node/906436#comment-3440140 / http://drupal.org/node/872260#comment-3454290) which are still opened; I agree that actually PE instructions are not very clear ...

ayalon’s picture

ayalon commented
StatusFileSize
new panels_everywhere_bug_template.patch692 bytes

Dear merlinofchaos

I had exactly the same problem. It is the default setting of panels_everywhere and it is not working. Only if I activate

Please do not force the user to override the whole template. For example I override the apachesolr search pages with the site_template and it's not necessary to build the whole page with panels_everywhere.

I would like to use my own page template.

settings not working:
(x) Enable Panels Everywhere site template
( ) Enable Panels Everywhere site template for the admin theme
(x) Provide a sample variant for the site template
( ) Override the page template

settings working but not possible with custom template:
(x) Enable Panels Everywhere site template
( ) Enable Panels Everywhere site template for the admin theme
(x) Provide a sample variant for the site template
(x) Override the page template

I compared the module with a previious version where it's working perfectly and uncommented the "evil" lines.

See attached patch

kars-t’s picture

kars-t commented
Status: Active » Needs review

Hi,

in regards of #885848: Using mytheme_preprocess_page()

if you want to override the page.tpl.php but still use an own version from inside of your theme here is a solution:

This goes into your themes template.php

function mytheme_preprocess_page(&$vars) {
  if (!empty($vars['panels_everywhere_site_template'])) {
    $vars['template_file'] = 'page';
  }
}

function mytheme_theme_registry_alter($registry) {
  if (!panels_everywhere_should_override_theme())
    return;

  // Test to see if we should exclude the administrative theme.
  if (!variable_get('panels_everywhere_site_template_enabled_admin', FALSE)) {
    global $theme;
    $admin_theme = variable_get('admin_theme', '0');
    if ($admin_theme && $admin_theme == $theme) {
      return;
    }
  }

  $registry['page']['theme paths'][] = drupal_get_path('theme', 'mytheme');
}

I set this to "Needs review" so someone can please test this and set it to fixed if it worked.

sleeping_at-work-’s picture

sleeping_at-work- commented

Enabling the "Override page template" option cuts out theme preprocess functions ... maybe the one by Kars-T won't be the right solution, but I'll test and report here ...

mcpuddin’s picture

mcpuddin commented
Status: Needs review » Closed (duplicate)

Alot of these issues (#952844: Unchecking box to 'Override the page template' also disables the site template, #906436: "Override the page template" cannot be disabled, #962400: fallback page not returned) that need to be reviewed are all related to the same issue that 6.x-1.x-dev is not supporting "not overriding page.tpl.php". I have looked at all these listed issues and contributed a patch to #906436-10: "Override the page template" cannot be disabled that should be able to resolve all of them. Can someone please review?

In order to aggregate all these issues together, I am marking this as a duplicate of #906436: "Override the page template" cannot be disabled since I contributed the patch in that issue.