Undefined index: drush_batch_process_finished

Looks fine to me. I'll let Greg review and commit.

Committed a slight variant of the proposed patch.

Still getting this in Drush 4.4.

This was only fixed in 5.x-dev. It could be backported, though.

It was fixed only for batch_6.inc... but it seems to me it was not a proper fix.

$data['context']['drush_batch_process_finished'] is not declared anywhere but used in that line. It seems a lapsus when coding this because what is done in other part is drush_set_option('drush_batch_process_finished').

Why it didn't produce a failure never? Perhaps checking for !$data is enough.

When I apply the patch in #6 to Drush 4.5-rc1, and run drush upc --no-core -l example1.com it goes into an endless loop. See attachment for debug.

Changing this to Major, as it completely leaves me without the drush upc functionality.

The lapsus was from me in #6. drush_set_option('drush_batch_process_finished') is set in a backend process and obtained in the main project throught $data['context'].

fixed in master.

The patch in #10 works great when applied to Drush 4.5-rc1 :) No longer an issue with this patch.

suscribe

Here's the patch ported to 4.4 (modifying the batch_7.inc file)

I rerolled it for drush 4.5

Committed to 4.x