A menu item description, "Administer content", is missing a period. [#948416]

  $items['admin/content/node'] = array(
    'title' => 'Content',
    'description' => "Administer content",
    'type' => MENU_DEFAULT_LOCAL_TASK,
    'weight' => -10,
  );

Titles do not end in periods, but i think all descriptions are supposed to.

If this is a violation of coding standards, i'll roll a tiny little patch when the Drupal 8 branch opens. Not even bothering for Drupal 7.

Comment	File	Size	Author
#1	948416-1.patch	565 bytes	David_Rothstein

Comments

Comment #1

David_Rothstein commented 25 October 2010 at 02:21

Version:	8.x-dev	» 7.x-dev
Status:	Active	» Needs review

Status	File	Size
new	948416-1.patch	565 bytes

I got a patch committed a little while ago that fixed a bunch of these, but must have missed this one. I think it's a straight up grammatical bug (albeit minor), so it can be fixed in D7.

However, I think the reason I missed it is.... it is never displayed anywhere? As far as I know, default local tasks don't have any reason to have a description (they inherit things from their parent), and certainly many others in core do not have them. So maybe we can just remove it, as in the attached? If so, it won't even count as a patch that affects the string freeze :)

Comment #2

mlncn commented 25 October 2010 at 22:05

Status:

Needs review

» Reviewed & tested by the community

Ha! Very good point! I can't find any way it or other local task descriptions could be displayed, and i checked through taxonomy and comment module among others and cannot find any local tasks, default or non, that have a description.

Drupal can now be one less line of code and one less headscratcher shorter!

Comment #3

mlncn commented 26 October 2010 at 17:20

(What perhaps should be revisited for Drupal 8 is displaying MENU_LOCAL_TASK descriptions as tool tips - HTML titles - on the menu tab link— i cannot find any issue discussing this, but it would make sense.)