Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The block_callback field in the {menu_router} table seems to be a curious leftover from pre-D6 at least.
It's only used in system_main_admin_page():
if ($item['block_callback'] && function_exists($item['block_callback'])) {
$function = $item['block_callback'];
$block['content'] .= $function();
}
There's not a single item in my menu_router table that has this set. On D6, there's only one, and it's not even relevant to system_main_admin_page()!
I reckon we can get rid of this.
Comment | File | Size | Author |
---|---|---|---|
#11 | 943558-11.patch | 1.59 KB | David_Rothstein |
#6 | 943558-6.drupal.remove-menu-block_callback.patch | 2.85 KB | joachim |
#4 | 943558.drupal.remove-menu-block_callback.patch | 2.54 KB | joachim |
#1 | 943558.drupal.block_callback-test.patch | 1015 bytes | joachim |
Comments
Comment #1
joachim CreditAttribution: joachim commentedLet's see what the testbot makes of this ;)
Comment #2
joachim CreditAttribution: joachim commentedTestbot status 'ignored'? Is that because this is on 8? Hmm let's try it on 7.
Comment #3
moshe weitzman CreditAttribution: moshe weitzman commentedtests pass. kill it.
Comment #4
joachim CreditAttribution: joachim commentedHere's a patch that removes it all.
Comment #5
moshe weitzman CreditAttribution: moshe weitzman commentedNeeds an update function to drop the column, no?
Comment #6
joachim CreditAttribution: joachim commentedSo we do.
Comment #7
moshe weitzman CreditAttribution: moshe weitzman commentedLooks ready to me.
Comment #8
catchnice.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedIt's not all the way gone yet...
Comment #11
David_Rothstein CreditAttribution: David_Rothstein commentedNow it is :)
By the way, is the original commit here an API change? It seems like it sort of is, although I'm not convinced this functionality worked as intended in D7 anymore anyway.
Comment #12
moshe weitzman CreditAttribution: moshe weitzman commentedRTBC.
Comment #13
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.