Hello,

I did a really small patch that avoid one SQL in system_region_list() function. Because we have the current theme information available as a global variable, there is no use to do an SQL query to fetch it back (again) when asking the current theme region list.

I known that D7 needs the patch, then backport it to D6, but the system_region_list() has changed, and does not work the same anymore, so this is NOT about D7 here, this is a really small performance improvement for D6.

CommentFileSizeAuthor
#5 system.module-6.x-system_region_list-performance_fix.patch839 bytespounard
#2 system.module-system_region_list-performance_fix.patch1000 bytespounard
#1 system.module-system_region_list-performance_fix.patch999 bytespounard

Comments

pounard’s picture

pounard
Primary language French
commented
StatusFileSize
new system.module-system_region_list-performance_fix.patch999 bytes

Patch attached.
EDIT: Wrong patch attached, old non working version.

pounard’s picture

pounard
Primary language French
commented
StatusFileSize
new system.module-system_region_list-performance_fix.patch1000 bytes

Right patch attached (first one contains a typo error).

pounard’s picture

pounard
Primary language French
commented
Status: Needs work » Needs review

For fun.

Status: Needs review » Needs work

The last submitted patch, system.module-system_region_list-performance_fix.patch, failed testing.

pounard’s picture

pounard
Primary language French
commented
Status: Needs work » Needs review
StatusFileSize
new system.module-6.x-system_region_list-performance_fix.patch839 bytes

Patch made with git, should pass.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.