Threaded comment indentation broken [#93897]

Comment	File	Size	Author
#5	patch_72.txt	991 bytes	webernet
#3	patch_71.txt	796 bytes	webernet
	fix-indentation.patch.txt	801 bytes	leflo

Comment #1

leflo CreditAttribution: leflo commented 14 November 2006 at 15:44

Version:

5.0-beta1

» 5.x-dev

Log in or register to post comments

Comment #2

webernet CreditAttribution: webernet commented 23 November 2006 at 19:33

Status:

Needs review

» Needs work

There does appear to be a vaild bug here. Adjacent comments in the nested list only differ by one level.

Unfortunately patch doesn't apply.

Log in or register to post comments

Comment #3

webernet CreditAttribution: webernet commented 8 December 2006 at 17:08

Title:	Indentation fails	» Threaded comment indentation broken
Status:	Needs work	» Needs review

File	Size
patch_71.txt	796 bytes

Currently, if a comment is indented, the next comment in the threaded list appears to be at most 1 level higher, even if it should be a top-level comment.

Currently it looks like this:
Comment 1
-Comment 1.1
--Comment 1.1.1
--Comment 1.1.2
-Comment 2

Should be:
Comment 1
-Comment 1.1
--Comment 1.1.1
--Comment 1.1.2
Comment 2

Patch seems to fix the issue, not sure if it's the right/best approach though.

Log in or register to post comments

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 8 December 2006 at 18:42

I think this patch looks good. I was thinking that isnce the while loop decrements $last_depth setting it immediately after is unnecessary, but that while loop does not always run and the last_depth needs to be set. It may be that the $last_depth = $comment->depth should be moved to just before the else.