locale_* tables need %b

Is there a reason we're moving towards binary data for the source? If so, we have to modify locale to work properly with binary data by using %b without single quotes in the INSERT/UPDATE queries and adding a db_decode_blob() on SELECT. Comments?

Instead of changing the db schema this late in the release cycle is generally not a good idea. Have you considered using %b to properly encode the blobs.

I count at most 33 places:

> grep -r {locales_target} . | grep translation | grep '%s' | wc -l
19
> grep -r {locales_source} . | grep source | grep '%s' | wc -l
14

And the change is simply changing '%s' to %b.

As far as I can tell, none of these use LIKE:

> grep -r {locales_source} . | grep source | grep LIKE | wc -l
0
> grep -r {locales_target} . | grep translation | grep LIKE | wc -l
0

However, if blob/btyea are still not suitable, then there must be a locale_update_N() added to locale.install to make this table change for existing sites.

Please enlighten me -- would a character varying be a solution? I know it's late in the release cycle, but... maybe this is the simpler solution and it affect pgsql only.

Character varying?

We use blobs to enforce case sensitivity on mysql.

Following sammys' advice

[06:36] [sammys] chx: so as I see it, we revert the type to text as it was for 4.7
[06:37] [sammys] chx: for pgsql only

I rolled a patch. He will provide some upgrade queries for the beta testers who want to keep their databases but an update will not be provided.

as chx has already mentioned we're reverting to the 4.7 implementation. Don't commit yet. i'm adding some comments to the schema.

Here's the patch with comments in the schema so we don't have this problem again.

Committed to HEAD with stylistic improvements to the comments.

Here are the pgsql queries to manually update any alpha/beta 5.0 installs to the new schema.

ALTER TABLE locales_source RENAME source TO source_old;
ALTER TABLE locales_source ADD source text;
UPDATE locales_source SET source = encode(source_old, 'escape');
ALTER TABLE locales_source ALTER source SET NOT NULL;
-- **** NOTE: only do this step if you're quite sure the values match ****
ALTER TABLE locales_source DROP source_old;

Might as well give you a pasteable one for both locales_source and locales_target tables.

-- converting locales_source table
ALTER TABLE locales_source RENAME source TO source_old;
ALTER TABLE locales_source ADD source text;
UPDATE locales_source SET source = encode(source_old, 'escape');
ALTER TABLE locales_source ALTER source SET NOT NULL;
--
-- converting locales_target
ALTER TABLE locales_target RENAME translation TO translation_old;
ALTER TABLE locales_target ADD translation text;
UPDATE locales_target SET translation = encode(translation_old, 'escape');
ALTER TABLE locales_target ALTER translation SET NOT NULL;
--
-- **** NOTE: only do this step if you're quite sure the values match ****
--
ALTER TABLE locales_source DROP source_old;
ALTER TABLE locales_target DROP translation_old;

We decided against it as the only people needing this are those that are using the beta release.