There are lots of empty newlines before and between the aggregated lines, if the css aggregation is enabled.

CommentFileSizeAuthor
#12 css-aggregation-whitespace-reroll4.patch2.81 KBCoornail
#10 css-aggregation-whitespace-reroll3.patch2.81 KBCoornail
#8 css-aggregation-whitespace-reroll3.patch.txt2.81 KBCoornail
#5 css-aggregation-whitespace-reroll2.patch2.82 KBCoornail
#2 934774-css-aggregation-whitespace.patch453 bytesdamien tournoud
css_whitespace.patch455 bytesCoornail

Comments

Status: Needs review » Needs work

The last submitted patch, css_whitespace.patch, failed testing.

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 934774-css-aggregation-whitespace.patch453 bytes

This makes sense. Rerolled as a proper patch. I guess some tests will fail.

damien tournoud’s picture

damien tournoud commented
Version: 7.0-beta1 » 7.x-dev

Status: Needs review » Needs work

The last submitted patch, 934774-css-aggregation-whitespace.patch, failed testing.

Coornail’s picture

Coornail commented
StatusFileSize
new css-aggregation-whitespace-reroll2.patch2.82 KB

Fixed the test css also:

zserno’s picture

zserno commented
Status: Needs work » Needs review

Trigger the bot.

Status: Needs review » Needs work

The last submitted patch, css-aggregation-whitespace-reroll2.patch, failed testing.

Coornail’s picture

Coornail commented
Status: Needs work » Needs review
StatusFileSize
new css-aggregation-whitespace-reroll3.patch.txt2.81 KB

Rerolling again...

Coornail’s picture

Coornail commented

Asking the bot kindly to test.

Coornail’s picture

Coornail commented
StatusFileSize
new css-aggregation-whitespace-reroll3.patch2.81 KB

Forgot to rename it properly...

Status: Needs review » Needs work

The last submitted patch, css-aggregation-whitespace-reroll3.patch, failed testing.

Coornail’s picture

Coornail commented
StatusFileSize
new css-aggregation-whitespace-reroll4.patch2.81 KB

Let's try it again

Coornail’s picture

Coornail commented
Status: Needs work » Needs review
pp’s picture

pp commented
Status: Needs review » Reviewed & tested by the community

It works for me.

1. go to admin/config/development/performance
2. switch on "Aggregate and compress CSS files into one file."
3. Refresh, the browser and watch the css files. I see the empty lines.
4. use patch (patch -p0 < ../css-aggregation-whitespace-reroll4.patch )
5. go to admin/config/development/performance and clear all cache
6. Refresh, the browser and watch the css files. I cant see the empty lines. -> the patch is good.

One question: Is the newline necessary?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -CSS aggregation

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +CSS aggregation

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.