The list of changes in CHANGELOG.txt should consist info about the new Bartik theme;)

Tormi

Comments

webchick’s picture

Category: feature » task
Issue tags: +Novice

Yes, it should.

Tagging as a "Novice" issue.

damien tournoud’s picture

Version: 7.0-beta1 » 7.x-dev
Priority: Minor » Normal
chrisparsons’s picture

Status: Active » Needs review
StatusFileSize
new581 bytes

I'm not entirely convinced if "default core theme" is specific enough, since Seven's the "default administration interface theme."

Here's a patch to start the ball rolling anyhow.

tstoeckler’s picture

Status: Needs review » Needs work

Instead of
"Added Bartik theme as the default core theme."
how about
"Added Bartik theme as the default theme."
?
No need to mention the rather jargon-y word 'core' here, in my opinion.

chrisparsons’s picture

StatusFileSize
new576 bytes

That makes sense to me. I was thinking about if we had to distinguish them, since unlike in 6, we actually have a separate administration theme, but you're right that if we're going to worry about that, core isn't the word we need. New patch attached.

chrisparsons’s picture

Status: Needs work » Needs review

Forgot to change status message.

EvanDonovan’s picture

I think it should be "Added Bartik as the default theme." Otherwise, it sounds redundant. However, this is the format that was used for the other messages.

"Added Bartik as the default front-end theme" would be more industry-standard wording, but that got turned down when I proposed it in another context. Apparently, we don't use that word in Drupal land :)

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

#7 is correct. Still RTBC for the reason mentioned in #7.
Thanks chillin411 for the quick follow-up.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

#7 sounds like "needs work" to me?

EvanDonovan’s picture

@webchick:

Would it be possible for us to reword the CHANGELOG.txt as follows? (I suppose this would affect string freeze.)

* Added Stark theme to make analyzing Drupal's default HTML and CSS easier.
* Added Seven as the default administration interface theme.
* Added Bartik as the default front-end theme.

I think this would be better, even though "front-end" isn't used elsewhere, since most design-focused people would understand that word best.

If that is too much of a change, or if "front-end" is frowned upon, then I would reluctantly RTBC.

webchick’s picture

For clarity, nothing in CHANGELOG.txt affects string freeze. String freeze means stuff in t(). The .txt files are just documentation.

So yes, add as many items here as you want. :) The more the merrier!

webchick’s picture

And for "front-end", I don't have any particular like or dislike of that word. Maybe ping someone on the docs team for an opinion, though.

tstoeckler’s picture

Actually I would discourage the use of front-end here. There's much more to a front end than a theme. And, arguably, there's much more to a theme than front end.

EvanDonovan’s picture

@tstoeckler: What word would you suggest then? Are we in agreement that some kind of adjective is needed to describe Bartik's role?

@webchick: OK, cool. I didn't realize that CHANGELOG.txt was not bound by string freeze, since I presumed that it was also translated. Maybe I was wrong...?

tstoeckler’s picture

I would suggest:

* Added Stark theme to make analyzing Drupal's default HTML and CSS easier.
* Added Seven as the default administration interface theme.
* Added Bartik as the default theme.

if we want to change the existing ones as little as possible, but still be consistent.

If we don't care about changing the existing text a bit more, I would also suggest:
"administration interface" -> "administrative"

* Added Stark theme to make analyzing Drupal's default HTML and CSS easier.
* Added Seven as the default administrative theme.
* Added Bartik as the default theme.
EvanDonovan’s picture

Seven is not an interface, since it doesn't contain the code for the UI elements. I think we should just use the following and be done with it:

* Added Stark theme to make analyzing Drupal's default HTML and CSS easier.
* Added Seven as the default administration theme.
* Added Bartik as the default theme.

That will be consistent with the words used on the Appearance page.

tormi’s picture

Status: Needs work » Reviewed & tested by the community

#16 sounds like RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

There's no patch.

chrisparsons’s picture

Status: Needs work » Needs review
StatusFileSize
new1.13 KB

It seems like 16 ended up being consensus, and that's the one that reads the best to me. Re-rolled a patch to include these changes.

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community
dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. There are other things missing from CHANGELOG.txt -- would be healthy to review what's missing. Best done in a separate issue.

EvanDonovan’s picture

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.