I have found some strings that cannot be translated because they aren't wrapped into the t() function. I'm attaching a patch that fixes it.

CommentFileSizeAuthor
#5 checkout_settings.png49.86 KBadam_b
#2 uc_coupons_translations_2.patch1.64 KBdanillonunes
uc_coupon_translations.patch2.02 KBdanillonunes

Comments

adam_b’s picture

adam_b commented

I think there's another one, which is visible to the public:
"Enter a coupon code for this order."

Sorry, I haven't done patches before or I'd update it myself.

danillonunes’s picture

danillonunes commented
StatusFileSize
new uc_coupons_translations_2.patch1.64 KB

Great, adam_b!

Although this string can be changed via web interface, I think it should be translatable too. Here is the patch for this last string only.

adam_b’s picture

adam_b commented

Aha - where's the web interface for this? I'm actually using the String overrides module to change the wording.

danillonunes’s picture

danillonunes commented

In admin/store/settings/checkout/edit/panes

adam_b’s picture

adam_b commented
StatusFileSize
new checkout_settings.png49.86 KB

Ummm... maybe it's the drugs, but I'm not seeing anything relating to coupons on that page - see attached screenshot.

I get editing fields for:
- Checkout instructions
- Checkout review instructions
- Checkout completion message header
- Checkout completion message body (3x variants)
- Continue shopping message

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

It's on "checkout panes" under "Coupon discount settings", not "checkout messages". Probably not the most intuitive of places to keep it...

adam_b’s picture

adam_b commented

Got it... regular progress may now resume. Thanks, and sorry to hijack this thread.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Fixed

Committed. Thanks for the patches!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.