figover [figover]

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

Hello figover,

So sorry for the ridiculous delay in the further review of your application.

This looks good!

Before adding your theme to Drupal's CVS, you will need to remove LICENSE.txt (it gets added automatically) and collapse all $Id committername etc$ strings to just $Id$ -- they'll be expanded with your name and commit time :-)

Apologies again and thanks for contributing your theme.

Hi @figover, thanks for the application and patience. Congratulations, you have been approved.

The following points are recommendations for when you do put your code on drupal.org and develop it further; these are not requirements, simply suggested improvements based on my experience and knowledge of the existing Drupal community. Also, please read further about CVS access and resources.

1. Simply use $Id$ at the top of all text files, and the CVS packaging scripts will fill in the rest.

2. drupal_add_js(drupal_get_path('theme', 'teleco') . '/js/teleco.js', 'theme');
   

   Please use the theme.info correctly. http://drupal.org/node/171205

3.             array_pop($body_classes); // Remove 'section-node'
   

   Please put comments on individual lines as per coding standards.

4. Consider putting .css files in separate styles folder.

5. ; Information added by drupal.org packaging script on 2010-05-07
   version = "6.x-1.1"
   core = "6.x"
   project = "teleco"
   datestamp = "1241716288"
   

   As stated by the comment, this information is provided by the CVS packaging scripts and therefore you should not provide it yourself.

6. version = VERSION
   

   Please remove this as suggested by the comment above.

7. Consider putting $scripts at the bottom of the page template so that the page loads more efficiently.
8. Please use jQuery more effectively in your JS.
9. JS has coding standards as well. http://drupal.org/node/172169
10. Please use Drupal behaviors. http://drupal.org/node/114774#javascript-behaviors

Please read the following resources to make sure you know how to use CVS and the specifics to the Drupal CVS infrastructure, as well as how to be a good module maintainer on Drupal.org. The Drupal community is very large and dynamic; we welcome you as a module maintainer and hope that you embrace and challenge the Drupal community and continue to contribute.

• CVS reference: http://drupal.org/handbook/cvs/quickstart
• Maintaining modules: http://drupal.org/node/7765

Thanks to the following people who helped review this application, it is very appreciated:

• @kiamlaluno
• @Benjamin Melançon

--
Note: Please be patient with the CVS application process. It is all done by volunteers. Our goal is not to be arbitrarily slow or meticulous. Our goal is to get you CVS access and ensure that you are and will become a more responsible Drupal contributor. For a quick reference on what I look for in a code review, please see this article, or read the handbook page on how to review for reference.

I am giving credits to the users who participated in this issue.