The function definition uses $new_keys, but the parameters lists $keys_new.

Comments

Jaypan’s picture

Edit: I notice that the key is actually called $keys_new for Drupal 7. My report is in reference to the Drupal 6 documentation.

jhodgdon’s picture

Good catch. Probably the doc was ported from D7 and someone forgot to change the parameter name.

jhodgdon’s picture

Title:Documentation problem with db_add_field» db_add_field documentation has wrong parameter name
Issue tags:+Novice

good project for a novice doc contributor

Jaypan’s picture

Is that a hint? :D

jhodgdon’s picture

Sure. :)

We have this "Novice" tag to mark issues that are good for newbies, or for anyone who wants a quick project to do. If you'd like to do this one, please do. Just assign it to yourself, make a patch, attach it, and change the status to Needs Review.

daniels220’s picture

This problem looks fixed on the docs page. Does that mean this issue can be closed?

I'm just getting started contributing, btw, so please correct me if I missed something obvious.

jhodgdon’s picture

It doesn't look fixed to me on that page.

The Parameters section has the parameter name $keys_new, but the function itself uses $new_keys.

daniels220’s picture

Status:Active» Needs review
StatusFileSize
new623 bytes

...I am not having a good day today, am I. Well, here's a patch.

jhodgdon’s picture

Patch formatting is not OK, wrong file names at top

daniels220’s picture

StatusFileSize
new644 bytes

Regenerated with git.

jhodgdon’s picture

Status:Needs review» Reviewed & tested by the community

thanks, that looks fine

Gábor Hojtsy’s picture

Status:Reviewed & tested by the community» Fixed

Committed, thanks.

Status:Fixed» Closed (fixed)
Issue tags:-Novice

Automatically closed -- issue fixed for 2 weeks with no activity.