When viewing the theme configuration page of a theme that invokes the color module, one gets an fatal error (only PHP 5.0.5+ I think):

Fatal error: Only variables can be passed by reference in [...]\drupal\\modules\color\color.module on line 75

This is a common problem in newer PHP versions. PHP now accepts only variables to be passed by reference, if return values are passed by reference, it results in a fatal error.

The attached patch solves this issues.

CommentFileSizeAuthor
color.module.patch739 bytesFrando

Comments

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Concept is sound(seconded by chx). You can see the reference argument in the php docsarray_shift.

Tested in php 5.1.6 and color module performed as expected.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)