I'm adding this task to track Drupal 5.x support for this module. Don't know when I'll be able to work on it, but as soon as I download and install 5.0 on one of my machines, I'll try to determine how much work this will be.

CommentFileSizeAuthor
#11 directory.5+bugfix.patch7.4 KBmfb
#9 drupal5-directory-module.patch4.11 KBbeginner
#8 directory.info_.txt131 bytesbeginner

Comments

ajayg’s picture

ajayg commented

+1
Any updates?

mcurry’s picture

mcurry commented

Not yet. I've just checked in a few modules that have been updated to Drupal 5.

Anyone out there want to submit a patch? Surely someone who wants the Drupal 5 version has some time to do the conversion :D

guldi’s picture

guldi commented

Any new estimates concerning timing?
Thx!

ray007’s picture

ray007 commented

Subscribing

jmiccolis’s picture

jmiccolis commented
Status: Active » Needs review

Hi All,

I've done a first go at updating directory for drupal 5. My patch located here http://miccolis.net/random/directory_5_0_patch.tar.gz (as drupal.org wouldn't let me upload a tarball) and includes .info file.

I haven't tested too much, but this should allow people to at least turn the module on.

mfb’s picture

mfb
they or he
commented
Status: Needs review » Reviewed & tested by the community

This works for me so I'm going to push it along.. to ready to be committed.

beginner’s picture

beginner commented
Status: Reviewed & tested by the community » Needs work

The patch in the tarball seems pretty big. The patch in the duplicate issue mentioned below is much shorter. Also, it is customary to post the .info file and the patch in two follow ups rather than a tarball.
Since the other patch was shorter, I reviewed it first.

http://drupal.org/node/128771 is a duplicate of this issue.
It included the following patch, which I review:
http://drupal.org/files/issues/directory.module_0.patch
1) the patch didn't apply because it does not use standard Unix end lines (http://drupal.org/patch/submit#endings).
2) the patch includes a diff of the line "define('DIRECTORY_MODULE_VERSION" which shouldn't be there.
3) There are 3 mentions "for drupal 5" which are not actually needed (the module is going to be tagged Drupal-5 anyway.
4) several blank lines or spaces are added, making the patch actually longer than necessary.
But all of those are fairly minor cosmetic changes.
Other than that, the patch is fairly simple and at first glance I prefer it to the patch in #5.

I am going to have a closer look at the latter next, and come up with my own patch.

beginner’s picture

beginner commented
StatusFileSize
new directory.info_.txt131 bytes

Here is the .info file.
It is different from the two previously proposed ones:
It includes the line: version = VERSION
It does NOT include (and shouldn't) the line package = Directory Specific

beginner’s picture

beginner commented
Status: Needs work » Needs review
StatusFileSize
new drupal5-directory-module.patch4.11 KB

Here is the patch.

beginner’s picture

beginner commented

btw, I didn't include the following bugfix in my patch. It must be applied separately:
http://drupal.org/node/111790

mfb’s picture

mfb
they or he
commented
StatusFileSize
new directory.5+bugfix.patch7.4 KB

This issue is about drupal5 so I'm submitting this only for convenience -- a combined patch for drupal 5 upgrade and bugfixes http://drupal.org/node/111434 and http://drupal.org/node/111790

beginner’s picture

beginner commented
Version: master » 5.x-1.x-dev
Assigned: mcurry » beginner
Status: Needs review » Fixed

The patch has been applied.
A D5-dev snapshot will appear on the module's homepage in a few hours.

I'll create an official release in a few day, after I have committed a few fixes.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)