Garland: Custom logo distorts theme

Bumping priority of this to critical; changing the logo is the very first thing a user's going to want to do with their theme; if Garland/Minelli can't handle this gracefully, then this needs to be addressed.

There is no way to fix this without significantly changing the logo feature in the theme system. We'd need to enforce maximum dimensions by resizing the logo, and figure out a generic mechanism for themes to pass this information back to the theme system.

And even this wouldn't work well. In Garland/Minelli, the space available for the logo depends on whether the left sidebar is turned on or off, and this is not constant for a given site due to block visibility and all that.

An alternative fix is to make sure the breadcrumb section and main page content overlaps the logo, but this requires another horror ride of CSS tweaking. I for one am not spending another second on this theme. I burnt out long ago.

Updated to 5.x-dev

hi, is there a patch for this problem?
Or is the solution "don't use a custom logo"?
I think logos are one of the most important things on a HP and the garland theme ist one of the primary themes of drupal. There should not be such a big problem.

If you disagree please change the priority back.

1. Open themes/garland/style.css. (Make a backup first.)

2. Search for:

#wrapper #container #header {
  height: 80px;
}

3. Change the "80px" to the height of your logo. You might need to tweak it a bit.

This still active in new version... moving to D7.x-dev...

I have to agree on Steven on this one.
We need better image handling (for logo uploading and automatic resizing) for this..

Stefan

I did something slightly different (in 6.x, multisite), since my logo is both taller and wider than the default

1. copy drupal/themes/garland to drupal/sites/[sitename]/themes/garland
(so changes affect one site, not multiple sites)
2. edit drupal/sites/[sitename]/themes/garland/style.css as follows:
- in "#wrapper #container" change "padding: 0 20px;" to "padding 20px 20px;"
to move everything down 20px so there is room for primary links above the wider logo
- in "#wrapper #container #header" change "height: 80px;" to "height: 160px;"
to account for a 160px tall logo
- in "ul.primary_links" change "margin: 0;" to "margin: -20px 0;"
to position primary links 20px above the logo
3. in the GUI, change part of the theme configuration so that Drupal
(re-)creates drupal/sites/[sitename]/files/color/garland-[hex-digits] with the changes

I agree that it would be very nice if Drupal & Garland did more of this automatically.

Clif

I agree with Steven and StefanNagtegaal.

Though we would either require very flexible themes for this, or ImageCache in core (in progress).

Or simply a table-based theme, where "stretch-to-fit" works like a charm, and always did. Really, CSS is not very good for emulating a frameset (which is what we do in all these themes, really). Please don't yell at me, I just can't resist the urge to mention this ancient option (although I'm not going to really discuss this seriously).

@JirkaRybka: Table based themes are not an option. Tables are ment for tabular data, not for layout...
So, case closed...

I was just sarcarstic, I didn't mention to really sidetrack the issue (although, from real world experience, tables are indeed the only thing that really works in real life, I already learned to respect the table-free madness now running everywhere, despite having serious doubts about that), and I certainly didn't mean to cause this issue being "won't fix" - sorry if I caused that by the side-comment #12

This issue is supposed to be about a problem with Garland, right? So fixing status accordingly.

I agree that this is not the ideal solution, but this patch makes the main page content overlap the logo (instead of the other way around). Personally I have not played with the "stark" theme in D7 and maybe things are already moving in this direction but I would love for zen theme (http://drupal.org/project/zen) to be included in core.

Anywho ... we'll see if this patch is worth applying

The patch works but it's not ideal. Can something else be done now Imagecache is in core?

I suppose you could use imagecache to set a max height for the logo image, but that may not be desirable for some users. I don't think people would want that setting dictated...

I dont think there is a good solution here

@sdycroft ... do you have a suggestion?

Putting back to won't fix as no follow up from @sdrycroft.