When the title is active (for instance when the user clicks on the title text) it jumps out of position.

This rule cases the problem and I can't see any use for setting padding to zero here.

#overlay-title:active,
#overlay-close:hover,
#overlay-close:focus {
  padding: 0;
}
CommentFileSizeAuthor
#1 overlay-925398.patch564 bytesptrl
overlay-title-active.png6.21 KBptrl
overlay-title.png5.5 KBptrl

Comments

ptrl’s picture

ptrl commented
Status: Active » Needs review
StatusFileSize
new overlay-925398.patch564 bytes

Here is the patch.

betz’s picture

betz commented
Status: Needs review » Reviewed & tested by the community

Tested patch, did the trick, but i'm also wondering why this css rule exists in the first place.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Wow, never noticed that before. What a stupid bug! :)

Patch does indeed fix the problem but this close to RC I'd like to see some more testing of this in multiple browsers just in case it breaks something. To be on the safe side, I'll probably wait until next week to commit this.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Marking needs review, if you can ping back with what browsers you've tested this in and make sure IE 7&8 and Safari or Chrome are in that list, this is probably good to go.

ptrl’s picture

ptrl commented
Status: Needs review » Reviewed & tested by the community

Sorry missed your posts. This have been tested in IE7, IE8 Firefox 3.6, Safari 5 and Chrome 8 without any problems.

Been looking around if this code really does anything, but it looks like it was only placed there to annoy users :)

Tor Arne Thune’s picture

Tor Arne Thune commented

Tested this in Chromium 10.0.617.0 and Firefox 3.6.13 on Linux.

Before patch : Text jumps out of position when clicked.
After patch: Text stays in same position when clicked.

Conclusion: Fixed ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Wow, this totally fell off my radar! Sorry about that. :( Thanks a lot for the testing!

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.