is_null is mentioned in various files and modules. !isset is well known to be faster than is_null and should be usedd with variables. This patch replaces all the occurrences of is_null in the database system.

CommentFileSizeAuthor
#1 database-isset_is_faster_than_is_null-issue921582-2.patch3.16 KBmunzirtaha
database-isset_is_faster_than_is_null.patch2.86 KBmunzirtaha

Comments

munzirtaha’s picture

munzirtaha commented
StatusFileSize
new database-isset_is_faster_than_is_null-issue921582-2.patch3.16 KB

Oops! I missed one 'is_null' in the database layer.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

The PHP.net documentation says this works, plus isset() is ever so slightly more robust against undefined values. Thanks!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

munzirtaha’s picture

munzirtaha commented
Assigned: Unassigned » munzirtaha

Status: Fixed » Closed (fixed)
Issue tags: -Performance

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Performance

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.