Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
23 Sep 2010 at 09:04 UTC
Updated:
6 Jan 2020 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
szadok commentedOne module is called coder security: a cron which runs and tests sql sanity, based on coder
Second module is drupal instant, which performs an instant search in your drupal website (like google instant).
Comment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.
We just review a module/theme per applicant; let us know which module you want to be reviewed.
Comment #3
szadok commentedHello,
@kiamlaluno, thanks for clearing out things for me.
The attached module is called coder security. the module is based on coder and it tests for safe sql queries (according to coder standards).
The module runs once a day and tests all active modules and themes.
If the module finds unsafe sql queries, it issues an error to Drupal's watchdog and it sends a mail to a predefined mail address (default: site mail).
There is also an option to add known false positive modules (like ctools), so the test will not check them.
Comment #4
szadok commentedComment #5
bojanz commentedContributing to Drupal core doesn't require (or even take use of) a CVS account.
Comment #6
szadok commented@bojanz, I would like both: contributing modules (which is why I need a CVS account) and contributing to D7 core.
Comment #7
szadok commentedHello,
I would like to start from scratch and apply for a CVS account at drupal.org
The module I wish to present is Drupal instant - a module which performs an instant search on your Drupal website (similar to Google's new instant search).
The module relies on Drupal's search module and I plan to expand its functionality in the future
It works as follows:
The user types his search word, once he finishes typing (javascript keyup) the module automatically submits the search word and returns the search results.
The search results are displayed at the same page of the instant search.
There are currently no other alternatives to this kind of search.
Future plans:
1. Polish the module
2. Adding an auto suggestion mechanizsm, by Integrate with top searches module (auto complete search words & cache top searches)
3. Integrate with apache_solr search
Apart from that, I was asked by @z.stolar (http://drupal.org/user/48488) to co-maintain with him top_searches & pdir modules (please can contact him for approval)
Thank you,
Shlomi
Comment #8
z.stolar commentedI need szadok's help with my modules, so we can get them up and ready for D7 (issues are being created on the relevant projects). Please give him the necessary access to CVS, and let us move forward with it. Thanks.
Comment #9
szadok commentedI have (with the help of Raz Konforti) added integration with top searches which donates
-- autocomplete of search terms from top searches
-- Runs faster
@Todo:
* Fine tuning of the integration with top searches.
* Build a mechanism to update top searches.
Can you please approve my CVS account?
Comment #10
bojanz commentedLet's move things along.
szadok obviously has community approval (to a point), and the uploaded module looks okay.
No reason to further block him from contributing.
Comment #11
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #14
avpadernoComment #15
avpadernoI am giving credits to the users who participated in this issue.