* Assert that a select option in the current page is not checked.

CommentFileSizeAuthor
#4 919644_4.patch4.51 KBamateescu
#1 919644_1_assertOptionSelected.patch507 bytesscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new 919644_1_assertOptionSelected.patch507 bytes
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs review » Needs work
Issue tags: +Quick fix

Even though most of the function descriptions in DrupalWebTestCase still use the old-style second person form, we should convert these to use the third-person form whenever we're making changes to a function's Doxygen block.

So in this case the first line should read: "Asserts that a select option in the current page is checked."

scor’s picture

scor commented
Issue tags: +Novice

tagging for novice queue, that's an easy fix.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 919644_4.patch4.51 KB

Here is a patch for that.

It fixes the description for assertOptionSelected() and other occurences of the second person form in this file.

scor’s picture

scor commented
Status: Needs review » Reviewed & tested by the community

This patch looks good and includes the initial fix for assertOptionSelected().

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.