marianojofre [marianojofre]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

Hello marianojofre,

I apologize greatly for the long delay in this review.

If a delay of a week or more happens again, contact me directly or ask in #drupal-contribute on IRC for a further review.

The theme looks great, there are a few relatively minor things we'd like cleaned up before approving your CVS application:

• print $node->comment_count . ' Comentarios';
  All text strings in modules and themes are supposed to be wrapped in t(), the translate function. In this case i would recommend the format_plural function (which calls t() automatically).

  You can then include a Spanish translation of these text strings. http://drupal.org/project/barlow is an example of a theme with an included translation.

• Include only $Id$ in the comments at the top of files (and include this on all files), not the expanded version inherited from a file you are modifying.
• Please leave out LICENSE.txt (but thanks for being clear on the GPL!), as it gets added automatically.
• See also recommended CSS coding standards but in my opinion this project need not be held up over anything there.

Thank you so much for contributing, and i look forward to seeing Aim on Drupal.org!

Thanks Mariano.

Using a great base theme like Fusion is an excellent start (see also Omega for 7), integrating with Skinr as you did, you're going about it the right way to develop better themes.

From my perspective the CSS could be easier to read, though as noted and linked above CSS coding standards are still in draft, it should be two spaces and not tabs for indents there also, new lines between definitions, etc.

Good to go!

Hi @marianojofre, thanks for the application and patience. Congratulations, you have been approved. It is always great to see new themes.

The following points are recommendations for when you do put your code on drupal.org and develop it further; these are not requirements, simply suggested improvements based on my experience and knowledge of the existing Drupal community. Also, please read further about CVS access and resources.

1. /**
    * @file comment-wrapper.tpl.php
    * Default theme implementation to wrap comments.
    *
   

   This is not the default theme implementation to wrap comments. :) It is good that you copied the comments and variables, but update to make relevant to your theme.

2. Along the same line, you should copy the comments and description with the template file, for instance the comment.tpl.php

3. <div class="usuario">
   

   Not that I think English is a better language, but it is the standard for Drupal.

4. version = "6.x-1.0"
   core = "6.x"
   

   In your .info file, do not include version as the CVS packaging scripts will put this in automatically. Alos, you have duplicated the core attribute

5.   <?php print $scripts; 

   ?>
   Consider putting scripts at the bottom of the HTML so that the page loads more efficiently.

6. There are CSS coding standards for Drupal, please follow these. http://drupal.org/node/302199
7. Please remove Thumbs.db in the images directory before committing
8. Please make sure that you can license these images as GPL before committing them.

Please read the following resources to make sure you know how to use CVS and the specifics to the Drupal CVS infrastructure, as well as how to be a good module maintainer on Drupal.org. The Drupal community is very large and dynamic; we welcome you as a module maintainer and hope that you embrace and challenge the Drupal community and continue to contribute.

• CVS reference: http://drupal.org/handbook/cvs/quickstart
• Maintaining modules: http://drupal.org/node/7765

Thanks to the following people who helped review this application, it is very appreciated:

• @kiamlaluno
• @Benjamin Melançon

--
Note: Please be patient with the CVS application process. It is all done by volunteers. Our goal is not to be arbitrarily slow or meticulous. Our goal is to get you CVS access and ensure that you are and will become a more responsible Drupal contributor. For a quick reference on what I look for in a code review, please see this article, or read the handbook page on how to review for reference.

I am giving credits to the users who participated in this issue.