Running grep -r '/\* $I'

shows that there is some stuff to fix in some drupal core files:

system-messages.css
// $Id (It's missing the last $ so it doesn't have CVS version tag)

color.install and bartik/color/preview.js files:
Should use // $Id$ format instead of /* $Id$ */ (this last one should be used only for CSS files)

A small patch is included. I will mark it major because can be important that missing CVS version tag. Please, correct priority if necessary.

CommentFileSizeAuthor
#6 cvs-headers.patch1.01 KBtstoeckler
#2 Id_fixing2.patch1.01 KBcorbacho
Id_fixing.patch1.46 KBcorbacho

Comments

Status: Needs review » Needs work

The last submitted patch, Id_fixing.patch, failed testing.

corbacho’s picture

corbacho commented
Priority: Major » Normal
Status: Needs work » Needs review
StatusFileSize
new Id_fixing2.patch1.01 KB

Forget about the system-messages.css error. (It has been fixed already, I had a old checkout)

The other 2 still apply

jacine’s picture

jacine
she/her
Location New York
commented

#2: Id_fixing2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, Id_fixing2.patch, failed testing.

jacine’s picture

jacine
she/her
Location New York
commented
Component: drupal.css » other

This needs a re-roll.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new cvs-headers.patch1.01 KB

Rerolled.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Needs review » Reviewed & tested by the community

Thanks! :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.