larsdesigns [larsdesigns]

Hello, and thank you for applying for a CVS account.

As per requirements, you need to attach here the archive containing the proposed module. We just review a module/theme per applicant, though.

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

• Please check your module with the Coder module to make sure it follows the Drupal coding standards.
• Please provide a settings page for this module. It is bad practice to require users of your module to add stuff to the PHP code. (e.g. merchant ID at line 143). It would make the task of upgrading this module a nightmare once installed. It's only a few minutes work to provide a standardized settings form (See http://drupal.org/node/206761).
• I haven't installed the module, but why would the path 'avantlink' link to the core Drupal block administration page? If there is a reason for this, perhaps document this in the code.
• The query in avantlink_datafeed() should use {} brackets for table names, to be compliant with prefixed databases. Also, perhaps you should investigate if Ubercart provides an API function to get this data, since i'm not sure if Ubercart products enforce some of the fields in the query. (I assume users could remove the field content_field_image_cache from their Product content type, which would create a DB error).
• The drupal_add_js() call on line 114 points to a none-existing javascript file
• Could you rewrite the avant_sfpc_.js file to use jQuery, since all Drupal javascript is using this library. Also the avant_cookie_domain JS var should be coming from the Drupal.settings JS object, which in turn should be filled with a variable from the settings page.
• Please use the Drupal Form API for adding form elements in avantlink_google_merchant().
• The avantlink.install file could be removed since it's empty. If you'd add functionality to it, make sure to make the CVS header on line 2 is an empty one instead of the current one.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.