Control statements should have one space between the control keyword and opening parenthesis, to distinguish them from function calls.

CommentFileSizeAuthor
#4 system-coding_standard_violation-issue915322.patch1003 bytesmunzirtaha
#3 system-coding_standard_violation-issue915322.patch355 bytesmunzirtaha
module-system-region-coding-standard.patch300 bytesmunzirtaha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

munzirtaha’s picture

munzirtaha CreditAttribution: munzirtaha commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, module-system-region-coding-standard.patch, failed testing.

munzirtaha’s picture

munzirtaha CreditAttribution: munzirtaha commented
Issue tags: +Coding standards
FileSize
system-coding_standard_violation-issue915322.patch355 bytes

Fixing the patch for SimpleTest eyes only ;)

munzirtaha’s picture

munzirtaha CreditAttribution: munzirtaha commented
Status: Needs work » Needs review
FileSize
system-coding_standard_violation-issue915322.patch1003 bytes

Fixed another coding violation for the same module while changing the status to needs review.

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Reviewed & tested by the community

yup

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Coding standards

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Coding standards

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.