I'd like to have the ability to disable the 'by location' tab in the search page, and so I have attached a patch which allows users to disable this if they wish (it is still displayed by default).
(I've also changed a string in the location settings page to remove reference to CivicSpace specifically)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | location_searchpermission.patch | 1.9 KB | geodaniel |
| locationsearchoptional.diff | 3.58 KB | geodaniel |
Comments
Comment #1
geodaniel commentedAnkur, any thoughts on this one? Ideally I'd like to be more flexible in what search options we give to our users.
Comment #2
nedjo+1, the search by location isn't always wanted.
(The unrelated removal of CivicSpace is also needed.)
Comment #3
geodaniel commentedThis could also be done as a permission (see attached patch), though that would cause the search by location tab to disappear when people upgraded their modules.
Comment #4
ankur commentedWell, for the perm patch, we could include a db update in the .install file that runs the appropriate queries to add the 'search by location' access to all of the existing roles...
But I'm undecided myself about whether it'd be better to have it as a permissions thing or as a configurable setting for everyone.
I can imagine us wanted to be selective about who gets to do this if the search was for users, but I can't imagine what situations we'd want to prevent some people from search content by location and allow others to be able to search content by location.
Comment #5
2houseplague commentedI looked for the way to turn this off in admin >> search, if that tells you anything. The intuitive thing would be to allow the admin to enable or disable "realms", i.e users, locations, opensearch... globally, then to disallow by role.
Comment #6
lias commentedBeing able to turn it off would be a great option, especially via permissions and by role.
lsabug
Comment #7
geodaniel commentedTo keep this change as simple as possible, maybe the global on/off switch would be the best solution? I'd love to get this in... :)
Comment #8
bdragon commentedThis has been fixed in HEAD since march 2008 by splitting the search interface off to a seperate module.
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.