CVS edit link for maxime-rabot
Give the theme developer a better way to create their own theme and share my experience as Webdesigner.My theme is named "Bid Daddy".
BigDaddy is not a ready-made theme but only a good basis for theme developers. This theme will facilitate theme development and give an optimal start to have a clean rendered HTML and CSS output. It's up to the themer you to add more templates, theme functions or css to adapt it to his Web project.
I concentrate myself to create CSS as clean as possible with optimal typography rules to enlarge legibilty.
I documented the most files so that the themer can easily work with it.
I few settings will help to achieve legibility like the Syncotype setting for vertical rythm or the 960 grid setting to work with grids.
-> Here is the actual test site of this theme: http://drudev.dev3.webenabled.net/
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | bigdaddy.zip | 58.45 KB | maximer |
| #11 | bigdaddy.zip | 60.55 KB | maximer |
| #9 | bigdaddy_02.zip | 66.13 KB | maximer |
| #1 | bigdaddy.zip | 61.76 KB | maximer |
Comments
Comment #1
maximer commentedComment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
Comment #3
maximer commentedOk, thanks a lot.
Do you know when approximately the reviewing will be done?
Comment #4
avpadernoI am sorry to say I cannot say how much it will take to approve this application.
The process is a little slow, and it can be discouraging for who applies.
Comment #5
maximer commentedOk, I will be waiting. Thanks for your answers and your time.
Have a nice week ;)
Comment #6
maximer commentedComment #7
avpadernoComment #8
maximer commentedOh, sorry for the wrong changes. But I wanted to replace my old username 'maxime-rabot' with my new username 'maximer'
Comment #9
maximer commentedI have updated my theme files. See attached file.
Comment #10
mlncn commentedHello Maximer,
So, so sorry for this ridiculously long delay in your review. I think there's a shortage of theme reviewers!
Function comments in template.php should follow coding standards as in modules: no line between the comment and the function, a second asterisk at the top, and only a single space indent for the comments in general. Please make those changes when or before you commit your theme.
Also, review the draft CSS coding standards for changes you can make your code more consistent: http://drupal.org/node/302199
Files should have a comment at the top with a $Id$ tag. For instance, custom-layout.tpl.php should have just
// $Id$at the top, not// $Id: panels-twocol-stacked.tpl.php,v 1.1.2.2 2010/07/20 19:06:04 merlinofchaos Exp $– the $Id$ will be expanded to have your name and date when you committed!Also, remove LICENSE.txt before committing. It is added automatically.
Great to see a theme and subtheme! Thanks for contributing!
Comment #11
maximer commentedHi Benjamin,
in the attached file, my updated theme. I hope everything is ok now with the comments.
Concerning the CSS coding standards, I want really to keep it like that (with selectors and properties on a single line). In my opinion, it give the user a better and quicker way to see his selectors. If the code is too long, now, with Firebug, you can easily find the right line and modify your properties. I create a few CSS files to create a consistent way to organize CSS. Hope it's ok for you.
Comment #12
maximer commentedYou think that it will be possible to have my theme available on Drupal.org this month?
Comment #13
avpaderno<?php print $block->subject; ?>, not<?php print $block->subject ?>.Comment #14
maximer commentedHere the new version with the changes needed.
Comment #15
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #18
avpaderno