This results in seamonkey complaining about bad XML when I have Content-Type: application/html+xml

XML Parsing Error: not well-formed
Location: http://www.cceldev.org/admin
Line Number 187, Column 18:      

Messaging & Notifications
-----------------^

This message is caused by the notifications module's hook_menu(), which has the following block:

  $items['admin/messaging'] = array(
    'title' => 'Messaging & Notifications',
    'access arguments' => array('administer notifications'),
    'description' => 'Administer and configure messaging and notifications',
    'page callback' => 'system_admin_menu_block_page',
    'file' => 'system.admin.inc',
    'file path' => drupal_get_path('module', 'system'),
  );

The menu system itself handles inserting the check_plain() call correctly. However, the system_main_admin_page()'s methods of getting at the 'title' key result in check_plain() not being called.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ohnobinki’s picture

Status: Active » Needs review
FileSize
660 bytes

This patch fixes the issue for me.

Status: Needs review » Needs work

The last submitted patch, system-theme_admin_block-check_plain.patch, failed testing.

ohnobinki’s picture

Status: Needs work » Needs review

The patch does not apply to D7 because of source code changes. I am not sure if this bug exists in D7 or not, but the above patch works fine for D6.

ohnobinki’s picture

FileSize
5.27 KB

This is as drupal-style-y that I can make it.

ohnobinki’s picture

Ooohh... that last attachment was meant to go on a different bug. I was wondering why it didn't show up on that other bug. Must be I'm trying to multiplex too many tabs :-/.

ohnobinki’s picture

Issue tags: +xhtml compliance

tag

killua99’s picture

Issue tags: -xhtml compliance

Status: Needs review » Needs work

The last submitted patch, system-theme_admin_block-check_plain.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.