Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This results in seamonkey complaining about bad XML when I have Content-Type: application/html+xml
XML Parsing Error: not well-formed Location: http://www.cceldev.org/admin Line Number 187, Column 18: Messaging & Notifications -----------------^
This message is caused by the notifications module's hook_menu(), which has the following block:
$items['admin/messaging'] = array(
'title' => 'Messaging & Notifications',
'access arguments' => array('administer notifications'),
'description' => 'Administer and configure messaging and notifications',
'page callback' => 'system_admin_menu_block_page',
'file' => 'system.admin.inc',
'file path' => drupal_get_path('module', 'system'),
);
The menu system itself handles inserting the check_plain() call correctly. However, the system_main_admin_page()'s methods of getting at the 'title' key result in check_plain() not being called.
Comment | File | Size | Author |
---|---|---|---|
#4 | git_deploy.module.txt | 5.27 KB | ohnobinki |
#1 | system-theme_admin_block-check_plain.patch | 660 bytes | ohnobinki |
Comments
Comment #1
ohnobinki CreditAttribution: ohnobinki commentedThis patch fixes the issue for me.
Comment #3
ohnobinki CreditAttribution: ohnobinki commentedThe patch does not apply to D7 because of source code changes. I am not sure if this bug exists in D7 or not, but the above patch works fine for D6.
Comment #4
ohnobinki CreditAttribution: ohnobinki commentedThis is as drupal-style-y that I can make it.
Comment #5
ohnobinki CreditAttribution: ohnobinki commentedOoohh... that last attachment was meant to go on a different bug. I was wondering why it didn't show up on that other bug. Must be I'm trying to multiplex too many tabs :-/.
Comment #6
ohnobinki CreditAttribution: ohnobinki commentedtag
Comment #7
killua99 CreditAttribution: killua99 commented#1: system-theme_admin_block-check_plain.patch queued for re-testing.