Something like "10, 50, 100, All"

"All" would be added to the drop down and display all items.

CommentFileSizeAuthor
#5 910256-pager-exposed-all.patch3.2 KBdawehner
#1 views-910256.patch3.2 KBdagmar

Comments

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new views-910256.patch3.2 KB

Please test this patch

dawehner’s picture

dawehner
Primary language German
commented 

+          $sanitized_options['All'] = t($this->options['expose']['items_per_page_options_all_label']);

Shouldn't we wait for the translatable patch to translate it here?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Exposed form plugins is working in this way at this moment. We have to fix all our t() call in translatable patch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Translatable patch is in, so this needs to conform. Perhaps other stuff in exposed filters also need to conform?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 910256-pager-exposed-all.patch3.2 KB

Here is a rerole.

Scanning the code didn't showed anything additional which has to be converted for translation patch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Changed 'All' to '- All -' for the label to conform to normal translatable All string.

Fixed typo: Wich -> Which

Committed to 6.x-3.x and 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.