See #769226: Optimize JS/CSS aggregation for front-end performance and DX

Applies to both D7 and D6. For D7, we want to leverage the new module .info file method.

CommentFileSizeAuthor
#7 mollom-DRUPAL-6--1.assets.7.patch1.39 KBsun
#5 mollom-DRUPAL-6--1.assets.5.patch1.45 KBsun
#1 mollom-HEAD.assets.1.patch1.68 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Unconditionally load Mollom's JS/CSS » Unconditionally load and aggregate Mollom's JS/CSS assets
Status: Active » Needs review
StatusFileSize
new mollom-HEAD.assets.1.patch1.68 KB

oh, how lovely is that! :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

This first one for HEAD is actually ready.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new mollom-DRUPAL-6--1.assets.5.patch1.45 KB

Backport to D6.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom-DRUPAL-6--1.assets.7.patch1.39 KB

hah, way too much D7 ;)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Tested manually + committed.

I just realized that this also fixes compatibility issues with various AJAX modules, which are either lazy-loading the entire comment form, or submitting the form via AJAX. Previously, the trouble was that our JS/CSS for CAPTCHAs didn't get loaded, so that should also be resolved now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 78d0d71 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #909438 by sun: unconditionally load and aggregate Mollom's JS/...

  • Commit 78d0d71 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #909438 by sun: unconditionally load and aggregate Mollom's JS/...