Country is not added to address when using google geocoding [#907564]

If the user only selected a country geoding was not working for me. Therefore I set "$q" to countrycode if empty.

I added a small fix to geocoding/google.inc in "google_geocode_location".

$q = _google_geocode_flatten($location);
  
if(empty($q)) {
 $q = $location['country']; 
}

$query = array(
    'key' => $key,
    'sensor' => 'false', // Required by TOS.
    'output' => 'xml',
    //'ll' => 0,
    //'spn' => 0,
    'gl' => $location['country'],
    'q' => $q, // $q goes here
  );

Patch attached.

Comment	File	Size	Author
#2	location-google_geocode_flatten-907564-2.patch	1.36 KB	rooby
	0-geocoding_google-6.x.3.1.patch	203 bytes	naden

Comments

Comment #1

bryancasler commented 27 October 2010 at 23:46

Status:

Active

» Needs review

Lets get this committed

Comment #2

rooby commented 8 January 2011 at 00:58

Title:

Google Geocoding fix

» Country is not added to address when using google geocoding

Status	File	Size
new	location-google_geocode_flatten-907564-2.patch	1.36 KB

Instead of checking the address after the call to _google_geocode_flatten() we should probably fix _google_geocode_flatten() itself.

This patch changes _google_geocode_flatten() to make it add the country to the address.
I also snuck in a little bit of code cleanup.

Can you test my patch for your use case?

The patch is against current cvs dev. Should apply to current dev download too.
Or you can manually apply to the 3.1 release if it doesn't apply cleanly.