Previous code for theme_links() gave only 'first' OR 'last' to each list element. But if there is only one item in the list, then it is both the first AND the last item and should have *both* classes. This patch fixes this problem.

CommentFileSizeAuthor
#4 li-first-and-last_0.patch900 bytesChrisKennedy
li-first-and-last.patch745 bytesjjeff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jjeff’s picture

jjeff CreditAttribution: jjeff commented

For reference:

http://drupal.org/node/89818

edmund.kwok’s picture

edmund.kwok CreditAttribution: edmund.kwok commented
Status: Active » Needs review
coreb’s picture

coreb CreditAttribution: coreb commented
Version: x.y.z » 5.x-dev

Moving out of the "x.y.z" queue to a real queue.

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented
Status: Needs review » Reviewed & tested by the community
FileSize
li-first-and-last_0.patch900 bytes

Works fine.

Minor tweaks in the updated patch: synced with HEAD, re-rolled from root, added period to the comment, and fixed potential E_ALL warning.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)