We are using checkout(http://drupal.org/project/checkout) in our online translation site www.translia.com now, and we're planning to switch to this module.

There are still one more feature we need: Grant different timeout to each node according to node content(or other factors). I have just started to add patched on our dev site. I have added a column release_time to table {content_lock}, and modified hook_cron implementation in content_lock_timeout module.

Is this a common request, if so, I would like to contribute my patches.

Comments

eugenmayer’s picture

eugenmayer commented

Every contribution is very welcome! I cant give you a free go that the feature will be included in every case, but in general iam always very opened to new features.

But please try to plan the features here in the issues, otherwise you probably dont implement it the way it should be done (according to API etc) and we cant take the patch in.
Features implemented in submodules are 5x more likely to get into the release. So dont try to bloat up the core code, rather provide patches for hooks, which then are utilized by the submodules ( of any kind ).

for the timeout-thing, please consider there is already a submodule since the last module, doing this job. All you need is extending this submodule.

shawnmeng’s picture

shawnmeng commented

Great, I will clean our code and work on the submodule.

ohnobinki’s picture

ohnobinki commented
Version: 6.x-2.1 » 6.x-2.4
Assigned: shawnmeng » ohnobinki

I suppose I could provide a hook to do this in content_lock_timeout.

ohnobinki’s picture

ohnobinki commented

The simplest way of providing hooks to do this sort of thing in content_lock_timeout only would cause content_lock_timeout_cron() to perform very inefficiently. So, this is a more complicated problem than it seems to be at first.

Yet, I can see that this would be a useful feature because certain nodes might be more sensitive and require drastically longer locks than others. So, I'll think about how to solve this for a long while... ;-)

pandaski’s picture

pandaski commented
Version: 6.x-2.4 » 7.x-2.x-dev
Issue summary: View changes
Status: Active » Closed (outdated)