on update preg_match_all()

There is a patch.

Note that the preg_match_all() will NOT have done its work right. If you are missing the 3rd parameter is always returns FALSE and thus the code within the if() block was ignored.

For your information, that means the ROBOT flags are lost.

Thank you.
Alexis

P.S. By the way, I'm glad to report that this upgrade did not otherwise destroy any data and since all of those were undefined on the site I first upgraded, it did not make any difference.

eule,

"no update" ?!

Do you mean that your update worked without any problem?

Thank you.
Alexis

eule,

Ah! That's because my fix doesn't add an update. It fixes an existing update which you already applied.

If you used ROBOT flags, then you lost them. (i.e. ROBOT flags are those used to "hide" some pages from robot indexes, etc.) If you had a backup you can restore your website and then apply the update again.

Thank you.
Alexis

I cannot review .tar.gz files.

The brain works funny once in a while... 8-)

I noticed that the system added an underscore but did not look further... It is a patch file albeit with the wrong extension.

Resubmitting.

Thank you.
Alexis

Changing the status back to needs review. 8-)

Thanks, that makes sense. I renamed it to $matches just to match the php default parameter name, even though its not used. Committed to CVS!
http://drupal.org/cvs?commit=432082