I currently work in a company (www.emergya.es) that develops some Drupal modules and themes and we want to share our finished projects with the Drupal community.
The first module I want to share is a module that generates metal song lyrics as Drupal nodes from the webservice of metalmaker.net
This module will show how to connect with a WebService from Drupal and how to parse some XML content in order to create Drupal nodes and Taxonomy with it.
I hope you enjoy this module as me.
Thank you very much.
Kind regards.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | metalmaker.tar_.gz | 6.02 KB | rteijeiro |
| #1 | metalmaker-6.x-1.0.tar_.gz | 9.53 KB | rteijeiro |
Comments
Comment #1
rteijeiro commentedHi.
Here you are the MetalMaker Module version 1.0 for review.
I hope you will enjoy it as me.
Thank you very much.
Kind regards.
Comment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.
As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.
Comment #3
rteijeiro commentedMetalMaker is a random Heavy Metal song lyrics and album titles generator.
This module imports randomly generated song lyrics as Drupal nodes assign them to a random album title as a taxonomy term.
This module calls the MetalMaker WebService functions, parses the result XML content and create one node by each song lyric and one taxonomy term by album.
You can set up some settings as number of generated songs, the probability of a song being instrumental even the song verbal tense.
It's a nice module for educational purpose and WebService testing with PHP SOAP. The code has been commented out in order to be simple and clear.
We use the QueryPath Module for parsing the result XML.
Initially it's based on the Soap Client Module but we are planning to recode it and use the PHP5 native SOAP library.
Are you ready for Metal ?
Comment #4
rteijeiro commentedI realized that the module didn't generate taxonomy terms because it's needed a taxonomy vocabulary with vid=2
Sorry this mistake (What a fail)
I am fixing this issue by creating the vocabulary on the module installation.
As well we are making some improvements in the settings form using AHAH in order to offer a better user interface.
If you want to share an oppinion to improve this module sure we will work on it.
Keep coding...
Comment #5
rteijeiro commentedIt's something wrong with the CVS application ?
Where could I create the project page for this module?
Do you need more info or documentation or something else?
Kind regards.
Comment #6
svendecabooterCould you upload your updated module (as mentioned in http://drupal.org/node/903432#comment-3444648) in this thread, so we can review that one?
Please also remove the LICENSE.txt from your module, as such a file will be automatically added once you committed your code to CVS.
As to the purpose of the module: I suppose it is tightly coupled to this particular webservice?
Would there be no way to make the source webservice for the lyrics a pluggable system, so lyrics could be fetched from other websites as well?
Since it would be better to have a more generic approach to this, rather than relying on one particular website to provide the data.
Comment #7
rteijeiro commentedHi, as you said, the module is coupled to this particular webservice but it lets the possibility of create our own dictionaries, so you will have infinity lyrics for your favourite music style songs.
I asked the webservice creator and he is giving me some feedback about this stuff.
If you need some more informations, just tell me.
I am fixing the issues posted on comment #4 and as soon as possible I will upload the updated module.
Please, publish this module. It's my first module and I love it so much... And it's better than Chuck Norris Module... ;)
Kind regards.
Comment #8
avpadernoThe module must first pass the review.
Comment #9
rteijeiro commentedYep, I know... Just joking.
Kind regards.
Comment #10
avpadernoComment #11
rteijeiro commentedI have made some fixes and updated this module and I want it to be reviewed.
Thanks a lot.
Kind regards.
Comment #12
svendecabooterPlease check the new project applications workflow at http://drupal.org/node/1011698, which is in effect since the migration to Git.
You should add this module to your Git sandbox, and apply in the Project applications queue if you feel the project is ready to become a full project.
Comment #13
svendecabooterSee also http://drupal.org/node/1075406 for more info on how to migrate to a Git Full Project application
Comment #14
avpadernoAs per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.
Comment #15
avpaderno