D7: drush dis [module] can disable profile

I've seen the message about 'standard' module being disabled many times but I never thought we actually did that!

I'm OK if we solve with a core patch to module_enable() or a fix in drush.

Assigning to our newest drush maintainer - jonhattan who will look after pm commands.

as I've seen, in D7 profiles are hidden modules. We did talk about not showing hidden modules and themes in pm-list command months ago.

drush_pm_list() does:

    if (($major_version >= 7) and (isset($project->info['hidden']))) {
      continue;
    }

I don't know how much we should hide hidden modules/themes in drush. We can move the discarding of hidden projects up to drush_get_modules() so there're will be no chance at all to do anything with hidden projects.

---

The other thing I see is that D7 provides two mismatching dependencies list:

dependencies/dependents and requires/required by. Consider this information for color module:

stdClass Object
(
    [uri] => modules/color/color.module
    [filename] => modules/color/color.module
    [name] => color
    [info] => Array
        (
            [name] => Color
            [description] => Allows administrators to change the color scheme of compatible themes.
            [package] => Core
            [version] => 7.0-dev
            [core] => 7.x
            [files] => Array
                (
                    [0] => color.module
                    [1] => color.install
                    [2] => color.test
                )
            [dependencies] => Array
                (
                )
            [dependents] => Array
                (
                )
            [php] => 5.2.0
            [bootstrap] => 0
        )
    [type] => module
    [status] => 1
    [schema_version] => 0
    [weight] => 0
    [required_by] => Array
        (
            [standard] => Array
                (
                    [name] => color
                )
        )
    [requires] => Array
        (
        )
    [sort] => -1
)

we are using requires/required_by instead of dependencies/dependents in environment_7.inc. I can't remember why we choose that. {snip} well we use it because dependencies is the .info array and requires is that array processed. Example:

dependencies[] = color (1.x)

    [requires] => Array(
            [color] => Array
                (
                    [name] => color
                    [original_version] =>  (1.x)
                    [versions] => Array
                        (
                            [0] => Array
                                (
                                    [op] => <
                                    [version] => 2.x
                                )
                            [1] => Array
                                (
                                    [op] => >=
                                    [version] => 1.x
                                )
                        )
                )

btw, it seems to me the mismatching is because dependents is never used in D7. If filled an issue for that #908578: dependents array key not used in any place across the code

attached a patch that discard hidden projects. It seems to be enough to fix this issue.

We have to preserve the ability to enable and disable hidden modules and themes. So we can't act like these don't exist.

Install profile is added to the list of modules in _system_rebuild_module_data() as required and hidden.

Alternate solution and fix for a wider bug in drush: required modules can't be disabled.

btw, I've realized that D6 has also the notion of hidden modules.

Looks like a terrific solution to me. Feel free to commit this, or I will do it in a couple days.

Commited.

I think this is to be backported to 3.x

3.x gets security fixes only.