Reproduce:

  1. Create a first node.
  2. Create a second node.
  3. Go to admin/content, click "edit" link for the FIRST node, re-save it, get redirected to admin/content.
  4. You see: The just updated node BELOW the second node, but it is newer. Also having an UPDATED marker, but you updated it yourself. (!)
  5. Click "edit" link for the SECOND node, re-save it, get redirected to admin/content.
  6. You see: The just updated node BELOW the first (previously updated, i.e., older) node. Also having a NEW marker. (?!)

How much can go wrong when we are missing automated tests? ;)

CommentFileSizeAuthor
#4 drupal.node-admin.4.patch2.31 KBsun
#3 drupal.node-admin.3.patch2.85 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sivaji_Ganesh_Jojodae’s picture

Title: Node updated status and content overview completely broken » Node updated status and content overview is incorrect

I can reproduce this, the updated node appears at the bottom instead of top. I guess this is because the table sorter is incorrect and it is already reported here #613666: Sorting on admin/content table is incorrect.

I disagree with the point #6, NEW marker for updated node it is not the case for me.

greggles’s picture

Title: Node updated status and content overview is incorrect » Nodes get a "new" marker for the editor if $_REQUEST['destination'] is set on node/NID/edit
Priority: Major » Normal

Re-titling based on comment #1 and that issue being fixed.. I also feel this is "by design."

At a minimum it's how Drupal has worked for a while and this is the first time I've seen it documented as a problem so downgrading the priority.

sun’s picture

Title: Nodes get a "new" marker for the editor if $_REQUEST['destination'] is set on node/NID/edit » TableSort default order broken / Node content overview order and updated status is incorrect
Priority: Normal » Major
Status: Active » Needs review
FileSize
2.85 KB

Absolutely no idea what the destination query parameter has to do with this issue.

Attached patch fixes the order of nodes. Updated marker not tackled yet.

Contains fragments of #850078: DTBNG Database layer is difficult to debug: Improve instrumentation

sun’s picture

FileSize
2.31 KB

Attached patch fixes both bugs. Someone up for writing tests?

greggles’s picture

@sun, the reason the updated marker doesn't get set is because the node/NID/edit page is something like node/2/edit?destination=admin/content and so you never visit the page so the history is never set. You can repeat the behavior with any destination parameter on the node edit screen which is why I stated it in a generic way rather than this specific set of steps.

In my opinion, that's not a bug. You've never seen the page so it should say "updated."

The sort issue is a clear problem and this patch does fix it.

sun’s picture

Title: TableSort default order broken / Node content overview order and updated status is incorrect » Node updated status marker incorrect on content overview
Status: Needs review » Needs work

#993026: Default sort on admin/content incorrect fixed the TableSort default order, including tests.

greggles’s picture

Priority: Major » Normal

In my opinion the remaining problem here is not something to fix, but it also seems unlikely to be "major" since this has been present in Drupal for ~4 years.

klausi’s picture

Status: Needs work » Active

So the status is active until we figure out whether this is a bug or intended behavior.

tmsimont’s picture

Is there any documentation on how the "new" and "updated" markers are designed to work?