Small output fixes for coding standards [#896366]

A few small changes are suggested for the template files:

To avoid unnecessary errors when E_ALL is set higher, instead of doing if ($var): it should be if (!empty($var)):

For template files it is cleaner to use

 if ():
endif;

and

 foreach ():
endforeach;

instead of

 if () {
}

and

 foreach () {
}

Because all fields can be enabled / disabled at will via the field settings, all fields should be optional, inc $map_link.

Comment	File	Size	Author
#2	location-n896366-2.patch	4.65 KB	damienmckenna
#1	location-n896366.patch	4.65 KB	damienmckenna

Comments

Comment #1

damienmckenna

TN, USA

commented 28 August 2010 at 21:15

Status:

Active

» Needs review

Status	File	Size
new	location-n896366.patch	4.65 KB

Here's a patch that cleans up the tpl files a little bit.

Comment #2

damienmckenna

TN, USA

commented 28 August 2010 at 22:24

Status	File	Size
new	location-n896366-2.patch	4.65 KB

Slight correction.

This patch sponsored by Bluespark Labs.

Comment #3

rooby commented 7 January 2011 at 06:04

Status:

Needs review

» Fixed

Thanks for the patch.
Committed with a few minor additions:
* A couple of indenting and spacing changes.
* A slight change also to location_distance.tpl.php
* Change to use format_plural in locations.tpl.php
* Changed a couple of extra echos to prints so they are now all consistent.
* A fix for the following code in the patch from #2:

+++ location.tpl.php	28 Aug 2010 21:29:02 -0000
@@ -1,55 +1,52 @@
+  <?php if (!empty($city)): ?>
+    <span class="locality"><?php print $city; ?></span><?php if ($province): ?>,<?php endif; ?>
+    <?php if (!empty($province)): ?>
+      <span class="region"><?php print $province_print; ?></span>
+    <?php endif; ?>
+    <?php if (!empty($postal_code)): ?>
+      <span class="postal-code"><?php print $postal_code; ?></span>
+    <?php endif; ?>
+  <?php endif; ?>

Province and post code would not display if city was not present.

http://drupal.org/cvs?commit=476314
http://drupal.org/cvs?commit=476310
http://drupal.org/cvs?commit=476312

Powered by Dreditor.