First, thanks for a great module. Big help to us.

The module stores United Kingdom country as uk, not gb, which is its "official assignment" per http://en.wikipedia.org/wiki/ISO_3166-1_alpha-2 (yes, I realize Great Britain is not a country, but a standard is a standard). It also uses lower case for these codes, which perplexes me. The above shows all codes as upper case with no mention of case insensitivity.

This leads to incompatibilities with, for example, Ubercart, which correctly uses 'GB' in its uc_countries table, and which also correctly stores the codes in upper case.

Is there a rational argument for these decisions or shall I be more constructive by contributing a patch?

CommentFileSizeAuthor
#2 addresses.zip234.13 KBdwightaspinwall

Comments

AlexisWilke’s picture

AlexisWilke commented

Hi dwightaspinwall,

To change something like the country code, we definitively need a patch that will go through all the database tables that uses that code and fix them. I go agree that UK should be fixed to GB. (Note that UK is exceptionally reserved for United Kingdom.)

As for the upper/lower case problem, the function used to get the codes can change the case for you. I would think that's enough. It could be a problem in the database in which case LOWER() or UPPER() must be used.

If you can provide a patch to fix the UK/GB problem then it would be great!

Thank you.
Alexis

dwightaspinwall’s picture

dwightaspinwall commented
StatusFileSize
new addresses.zip234.13 KB

The change is pretty trivial:

1) in addresses.inc, change:
'uk' => t('United Kingdom'),
to
'gb' => t('United Kingdom'),

2) rename file uk.inc to gb.inc

Unless I'm missing something, that should do it. Can't roll a patch since new files are involved, but I've attached a zip of the module with the changes (from the latest dev).

There are no "database tables" to change. While this module ought to be storing the country/province info in db tables, it is not. That would require a larger refactoring that I can't take on right now.

AlexisWilke’s picture

AlexisWilke commented

dwightaspinwall,

The following field defines the country with 2 letters (addresses/addresses.module:55):

    $items['country'] = array(
      'type' => 'varchar',
      'length' => 2,
      'title' => t('Country'),
      'description' => t('The ISO alpha 3 code of each country (its a 2-digit code).'),
      'default' => variable_get('addresses_country_default', 'us'),
      'display' => ADDRESSES_FIELD_SHOW,
      'theme' => array(
        'name' => t('The name of the country.'),
        'code2' => t('The 2-digit country code.'),
        'code3' => t('The 3-digit country code.'),
        'name_hcard' => t('An hcard/vcard representation of the country name.'),
        'code2_hcard' => t('An hcard/vcard representation of the 2-digit country code.'),
        'code3_hcard' => t('An hcard/vcard representation of the 3-digit country code.'),
      ),
      'token' => 'addresses_adr',
    );

In the addresses_user.install you have a foreach() that adds such fields to the user table:

      foreach ($fields as $field => $field_data) {
        db_add_field($update, 'addresses_user', $field, $field_data);
        $fields_existing[$field] = TRUE;
      }

The result is that you have a country field in databases that could be set to 'uk' in many databases. Those would need to be changed to 'gb'.

Thank you.
Alexis Wilke