Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.the language selection form is horribly huge on openatrium. we should make it a dropdown, or make it a dropdown once any element hits a certain number.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | rework-site-form1.patch | 4.41 KB | chertzog |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedThis is one of those (many) issues that I thought would be really easy, so took a stab at it, and it turned out to be a nightmare.
The hosting_site.form.js is filled with 'radios' assumptions, changing it to a select causes problems with other profiles that don't have multiple languages
Comment #2
anarcat CreditAttribution: anarcat commentedAgain, this points to yet another site form refactoring I guess...
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedI reckon we leave this for D6, and take advantage of the D7 ajax loveliness, and we can handle this issue there.
Comment #4
Steven Jones CreditAttribution: Steven Jones commentedTagging.
Comment #5
Steven Jones CreditAttribution: Steven Jones commentedYeah, this really isn't very simple is it. It would be nice to have at some point though.
Comment #6
ergonlogicComment #7
chertzogAs requested by anarcat in #967888: meta: refactor site form.
I commented out the pre_render function to demonstrate that this removes the need for hosting_site.form.js completely.
Here is a patch that changes the site form languages as well as the profile/platform stuff (as the are dependent on each other.
Comment #8
chertzogAnd actually, now that the hosting_site.form.js file is no longer needed, we could in fact change the profile / platform selectors to drop downs vs radios, if that was desired.
Comment #9
chertzogThis patch still applies.
Comment #10
helmo CreditAttribution: helmo commentedI've committed the patch from #7 minus the parts commented out.
As 00c9c271e4bb766bbb108b64391164bd94a23305
I've arbitrarily chosen count($languages) > 10 as condition to use a select instead of radio. (commit b12877de62f72957992b6b84a89b0b1e2efc8cdb)