Remove drupal_static() in _drupal_bootstrap_full()

Rasmus or not, no way we convert those require_once to require. The difference is minimum and the first is *way* more reliable.

Changing those require_once() to require() doesn't make any real difference in terms of performance, and would make the whole bootstrap process less robust.

For example, if a warning is triggered during bootstrap process, for example, error.inc will be loaded, and the require() call will explode, a module could want to load unicode.inc during a hook_boot, etc.

I'm not sure about removing the static, it seems to make sense to me.

Why do you want to replace require_once using require ? require_once is better and good for you. OPCode caches all optimize this method, and it may avoid potential crashes if somes modules attempt to require some of these files by themselves (using a light bootstrap or any other context like hook_boot() or such).

Here is a patch attached, that also fixes the wrong drupal_static() usage made in fix_gpc_magic(). If a miracle happens and this bootstrap method is run more than once, after the drupal_static() registry has been cleared, doing twice fix_gpc_magic() would totally break superglobals content.

This looks RTBC to me, but I want to give it bit more time for additional reviews.

Nice, thanks.

Looks good to me too.

If I had one thing to add, it would be a good comment about why those are not drupal_static() calls. It may worth it since a lot of developers could read this code and ask themselves why.

Committed to CVS HEAD. Thanks.