Remove CSS for the secondary menu block from Bartik, since the block/menu doesn't exist anymore [#891668]

This patch is a followup to #410646: "Secondary menu" exists but is no longer the default source for the secondary links - it should have gone in with the patch there, but was removed when all the Bartik code was taken out of that patch.

All it does is remove CSS for the "Secondary menu" menu/block that no longer exists in Drupal as a result of that patch.

In actuality, the surrounding code here seems a little suspicious, since (a) this is in an RTL file but doesn't seem to match any selectors from the LTR file, and (b) It seems to me like the styling for the "block-menu" class should cover this; no need to also target specific menus. But anyway, the patch for now just removes the obsolete rules for the secondary menu.

Comment	File	Size	Author
	bartik-secondary-menu-cleanup.patch	1.25 KB	David_Rothstein

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 26 August 2010 at 00:51

Status:

Needs review

» Needs work

Its weird because core does much styling itself to display them inline so for LTR not a lot more is needed, however core uses display: inline; which does not reverse the order of links when in RTL mode, so we have to float them to force the reversing.

Theres some styles in style.css for the secondary menu, need to dig them out also, one is:

// line 681 style.css
#footer-wrapper ul#secondary-menu {
  margin: 1em 0;
}

Could be more but I didn't see any others immediately.

Comment #2

David_Rothstein CreditAttribution: David_Rothstein commented 26 August 2010 at 01:04

Status:

Needs work

» Needs review

I don't think so, actually... that one is for "secondary menu" (the theme feature formally known as 'secondary links'), not "secondary menu" (the menu/block).

So that one we still need to keep around (though I suppose you will move/change it as part of #889982: Move secondary links to the header in Bartik since at that point the secondary links won't be in the footer anymore).

If this isn't proof of why we need to fix #698014: Theme settings for main/secondary variables mismatch with menu settings, I don't know what is :)